All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: vt8500: Fixup for missing gpio.h
Date: Sun, 30 Sep 2012 10:58:05 +1300	[thread overview]
Message-ID: <1348955885.25268.1.camel@gitbox> (raw)
In-Reply-To: <20120929211805.GF12999@quad.lixom.net>

On Sat, 2012-09-29 at 14:18 -0700, Olof Johansson wrote:
> On Wed, Sep 26, 2012 at 05:47:19AM +1200, Tony Prisk wrote:
> > mach/include/gpio.h was removed as part of the multiplatform-3.7
> > update. This patch removes the include from arch-vt8500/vt8500.c
> > 
> > Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
> > ---
> >  arch/arm/mach-vt8500/vt8500.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/arm/mach-vt8500/vt8500.c b/arch/arm/mach-vt8500/vt8500.c
> > index 4494993..587ea95 100644
> > --- a/arch/arm/mach-vt8500/vt8500.c
> > +++ b/arch/arm/mach-vt8500/vt8500.c
> > @@ -32,7 +32,6 @@
> >  #include <linux/of_platform.h>
> >  
> >  #include <mach/restart.h>
> > -#include <mach/gpio.h>
> >  
> >  #include "common.h"
> 
> Applied on top of existing vt8500/devel branch, thanks.
> 
> By the way, I noticed that there is no VT8500 defconfig in the tree, so there's
> no easy way for us to check for build breakages of your platform. You might
> want to add one.
> 
> Also, I noticed the following build warnings that you might want to address
> when I just built a very trivial config that enables the platform:
> 
> arch/arm/mach-vt8500/vt8500.c: In function 'vt8500_init':
> arch/arm/mach-vt8500/vt8500.c:81:8: warning: unused variable 'gpio_base' [-Wunused-variable]
> arch/arm/mach-vt8500/vt8500.c:80:27: warning: unused variable 'fb' [-Wunused-variable]
> 
> 
> -Olof

Argh.. I fixed that twice already.
Somehow I must have lost it while fixing up other problems.

I'll include that in the 3.7 cleanup stuff once -rc comes around.

Regards

Tony P

  reply	other threads:[~2012-09-29 21:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 17:47 [PATCH] Fixup for v3.7 Tony Prisk
2012-09-25 17:47 ` [PATCH] arm: vt8500: Fixup for missing gpio.h Tony Prisk
2012-09-29 21:18   ` Olof Johansson
2012-09-29 21:58     ` Tony Prisk [this message]
2012-09-30 12:00     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348955885.25268.1.camel@gitbox \
    --to=linux@prisktech.co.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.