From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: balbi@ti.com
Cc: Viresh Kumar <viresh.linux@gmail.com>,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org,
spear-devel <spear-devel@list.st.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver()
Date: Mon, 01 Oct 2012 13:47:17 +0300 [thread overview]
Message-ID: <1349088437.13371.167.camel@smile> (raw)
In-Reply-To: <20120927074039.GH12592@arwen.pp.htv.fi>
On Thu, 2012-09-27 at 10:40 +0300, Felipe Balbi wrote:
> On Thu, Sep 27, 2012 at 10:31:55AM +0300, Andy Shevchenko wrote:
> > From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >
>
> commit log would be great.
Will do.
> > static struct platform_driver dw_driver = {
> > + .probe = dw_probe,
>
> probe's in __init section. This is wrong. You need to change probe
> __devinit.
Have you checked this one
0272e93f364eac1a30f2831adcaca3dd633d5f14
Or might be I missed something?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2012-10-01 10:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 7:31 [PATCHv3 0/7] dw_dmac: split the driver and introduce PCI part Andy Shevchenko
2012-09-27 7:31 ` [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver() Andy Shevchenko
2012-09-27 7:40 ` Felipe Balbi
2012-09-27 8:16 ` viresh kumar
2012-09-27 8:16 ` Felipe Balbi
2012-10-01 10:47 ` Andy Shevchenko [this message]
2012-10-01 13:05 ` Felipe Balbi
2012-09-27 7:31 ` [PATCHv3 2/7] dmaengine: dw_dmac: add module alias Andy Shevchenko
2012-09-27 8:16 ` viresh kumar
2012-09-27 8:16 ` Felipe Balbi
2012-09-27 7:31 ` [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency Andy Shevchenko
2012-09-27 7:42 ` Felipe Balbi
2012-09-27 8:04 ` Andy Shevchenko
2012-09-27 8:02 ` Felipe Balbi
2012-09-27 8:17 ` viresh kumar
2012-09-27 8:17 ` Felipe Balbi
2012-09-27 7:31 ` [PATCHv3 4/7] dmaengine: dw_dmac: amend description and indentation Andy Shevchenko
2012-09-27 7:45 ` Felipe Balbi
2012-09-27 8:19 ` viresh kumar
2012-09-27 8:36 ` Andy Shevchenko
2012-09-27 7:31 ` [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver Andy Shevchenko
2012-09-27 7:49 ` Felipe Balbi
2012-09-27 8:08 ` Andy Shevchenko
2012-09-27 8:09 ` Felipe Balbi
2012-09-27 8:44 ` Vinod Koul
2012-09-27 9:43 ` Andy Shevchenko
2012-09-27 10:01 ` Vinod Koul
2012-09-27 10:11 ` viresh kumar
2012-09-27 10:32 ` Vinod Koul
2012-10-03 13:40 ` Andy Shevchenko
2012-10-08 10:17 ` Andy Shevchenko
2012-10-08 10:49 ` Viresh Kumar
2012-10-08 12:46 ` Andy Shevchenko
2012-10-08 13:27 ` Viresh Kumar
2012-10-24 11:13 ` Vinod Koul
2012-10-30 15:05 ` Andy Shevchenko
2012-10-30 15:19 ` Viresh Kumar
2012-10-30 15:39 ` Andy Shevchenko
2012-09-27 7:32 ` [PATCHv3 6/7] dma: move dw_dmac driver to an own directory Andy Shevchenko
2012-09-27 7:50 ` Felipe Balbi
2012-09-27 8:22 ` viresh kumar
2012-09-27 8:39 ` Felipe Balbi
2012-09-27 7:32 ` [PATCHv3 7/7] MAINTAINERS: add recently created files to dw_dmac section Andy Shevchenko
2012-09-27 7:51 ` Felipe Balbi
2012-09-27 8:12 ` viresh kumar
2012-09-27 8:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349088437.13371.167.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=balbi@ti.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.