From: Evgeny Voevodin <e.voevodin@samsung.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, kyungmin.park@samsung.com,
e.gorelkina@samsung.com, Evgeny Voevodin <e.voevodin@samsung.com>,
aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output.
Date: Mon, 01 Oct 2012 16:11:51 +0400 [thread overview]
Message-ID: <1349093511-28443-1-git-send-email-e.voevodin@samsung.com> (raw)
s->cpu_enabled is a massive, so s->cpu_enabled ? "En" : "Dis" returns
"En" always. We should use s->cpu_enabled[cpu] here.
Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
---
hw/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index 55871fa..4024dae 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -566,7 +566,7 @@ static void gic_cpu_write(gic_state *s, int cpu, int offset, uint32_t value)
switch (offset) {
case 0x00: /* Control */
s->cpu_enabled[cpu] = (value & 1);
- DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled ? "En" : "Dis");
+ DPRINTF("CPU %d %sabled\n", cpu, s->cpu_enabled[cpu] ? "En" : "Dis");
break;
case 0x04: /* Priority mask */
s->priority_mask[cpu] = (value & 0xff);
--
1.7.9.5
next reply other threads:[~2012-10-01 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 12:11 Evgeny Voevodin [this message]
2012-10-01 12:30 ` [Qemu-devel] [PATCH] hw/arm_gic.c: Fix improper DPRINTF output Peter Maydell
2012-10-02 3:50 ` Evgeny Voevodin
2012-10-04 11:50 ` Evgeny Voevodin
2012-10-04 11:59 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349093511-28443-1-git-send-email-e.voevodin@samsung.com \
--to=e.voevodin@samsung.com \
--cc=aliguori@us.ibm.com \
--cc=e.gorelkina@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.