All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@canonical.com>
To: "David S. Miller" <davem@davemloft.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Oliver Neukum <oneukum@suse.de>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	Ming Lei <ming.lei@canonical.com>
Subject: [PATCH 05/12] usbnet: int51x1: apply introduced usb command APIs
Date: Tue,  2 Oct 2012 14:51:16 +0800	[thread overview]
Message-ID: <1349160684-6627-6-git-send-email-ming.lei@canonical.com> (raw)
In-Reply-To: <1349160684-6627-1-git-send-email-ming.lei@canonical.com>


Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
 drivers/net/usb/int51x1.c |   52 +++------------------------------------------
 1 file changed, 3 insertions(+), 49 deletions(-)

diff --git a/drivers/net/usb/int51x1.c b/drivers/net/usb/int51x1.c
index 8de6417..ace9e74 100644
--- a/drivers/net/usb/int51x1.c
+++ b/drivers/net/usb/int51x1.c
@@ -116,23 +116,8 @@ static struct sk_buff *int51x1_tx_fixup(struct usbnet *dev,
 	return skb;
 }
 
-static void int51x1_async_cmd_callback(struct urb *urb)
-{
-	struct usb_ctrlrequest *req = (struct usb_ctrlrequest *)urb->context;
-	int status = urb->status;
-
-	if (status < 0)
-		dev_warn(&urb->dev->dev, "async callback failed with %d\n", status);
-
-	kfree(req);
-	usb_free_urb(urb);
-}
-
 static void int51x1_set_multicast(struct net_device *netdev)
 {
-	struct usb_ctrlrequest *req;
-	int status;
-	struct urb *urb;
 	struct usbnet *dev = netdev_priv(netdev);
 	u16 filter = PACKET_TYPE_DIRECTED | PACKET_TYPE_BROADCAST;
 
@@ -149,40 +134,9 @@ static void int51x1_set_multicast(struct net_device *netdev)
 		netdev_dbg(dev->net, "receive own packets only\n");
 	}
 
-	urb = usb_alloc_urb(0, GFP_ATOMIC);
-	if (!urb) {
-		netdev_warn(dev->net, "Error allocating URB\n");
-		return;
-	}
-
-	req = kmalloc(sizeof(*req), GFP_ATOMIC);
-	if (!req) {
-		netdev_warn(dev->net, "Error allocating control msg\n");
-		goto out;
-	}
-
-	req->bRequestType = USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE;
-	req->bRequest = SET_ETHERNET_PACKET_FILTER;
-	req->wValue = cpu_to_le16(filter);
-	req->wIndex = 0;
-	req->wLength = 0;
-
-	usb_fill_control_urb(urb, dev->udev, usb_sndctrlpipe(dev->udev, 0),
-		(void *)req, NULL, 0,
-		int51x1_async_cmd_callback,
-		(void *)req);
-
-	status = usb_submit_urb(urb, GFP_ATOMIC);
-	if (status < 0) {
-		netdev_warn(dev->net, "Error submitting control msg, sts=%d\n",
-			    status);
-		goto out1;
-	}
-	return;
-out1:
-	kfree(req);
-out:
-	usb_free_urb(urb);
+	usbnet_write_cmd_async(dev, SET_ETHERNET_PACKET_FILTER,
+			       USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
+			       filter, 0, NULL, 0);
 }
 
 static const struct net_device_ops int51x1_netdev_ops = {
-- 
1.7.9.5

  parent reply	other threads:[~2012-10-02  6:52 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02  6:51 [PATCH 00/12] usbnet: usb_control_msg cleanup Ming Lei
2012-10-02  6:51 ` [PATCH 03/12] usbnet: cdc-ncm: apply introduced usb command APIs Ming Lei
2012-10-02  6:51 ` [PATCH 04/12] usbnet: dm9601: " Ming Lei
2012-10-02  6:51 ` Ming Lei [this message]
2012-10-02  6:51 ` [PATCH 06/12] usbnet: mcs7830: " Ming Lei
     [not found] ` <1349160684-6627-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2012-10-02  6:51   ` [PATCH 01/12] usbnet: introduce usbnet 3 command helpers Ming Lei
2012-10-09  8:47     ` Oliver Neukum
2012-10-10  3:19       ` Ming Lei
     [not found]         ` <CACVXFVOPc0gG3UdWqJ0E+6wiwdPv5EoEgbJ0cvJ4oD4602Yp3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10  5:51           ` Oliver Neukum
     [not found]             ` <4085386.s0fOKMaRDP-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-10  8:17               ` Ming Lei
     [not found]                 ` <CACVXFVM7wPLXy0JL7QDnCaZFidwucTFf3t_38DuwukxWtOESHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10  8:39                   ` Oliver Neukum
     [not found]                     ` <1631246.gHVDWoZpLi-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-10  9:48                       ` Ming Lei
2012-10-10 10:08                         ` Oliver Neukum
2012-10-10 11:02                           ` Ming Lei
     [not found]                             ` <CACVXFVPDg89y7LyKLA0YUN7oA2rGfptfHLZhJrqBjTVPjsGdNg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10 11:25                               ` David Laight
     [not found]                                 ` <AE90C24D6B3A694183C094C60CF0A2F6026B702F-CgBM+Bx2aUAnGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2012-10-10 11:39                                   ` Oliver Neukum
2012-10-10 11:45                                 ` Ming Lei
2012-10-11  3:18               ` Ming Lei
     [not found]                 ` <CACVXFVMynoPm6_wYj2MD-5SvMpB7e1Wk94=XMp588rD8hU=eew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-11  4:11                   ` Oliver Neukum
2012-10-11  8:14                     ` Ming Lei
     [not found]                       ` <CACVXFVPjx+053r_-QB=8kPCDmk3va3feN9MYdLgpf=eRWGe05A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-11  9:05                         ` Oliver Neukum
     [not found]                           ` <1940520.W6hRn23j86-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-11 11:29                             ` Ming Lei
     [not found]                     ` <1588459.VLxBbnNMlP-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-11 14:36                       ` Alan Stern
2012-10-12  1:43                         ` Ming Lei
     [not found]                           ` <CACVXFVPdOkvKBBrshnmQv5cYVdDhi8j0V_WxNwBU9VuDsCLkXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-12 15:18                             ` Alan Stern
     [not found]                         ` <Pine.LNX.4.44L0.1210111030570.1170-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-12 13:51                           ` Oliver Neukum
2012-10-12 15:17                             ` Ming Lei
     [not found]                               ` <CACVXFVOChR3ZJSyjo44AMwzzjx5URWvEe25KY2eV5evJpF9D+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-12 15:33                                 ` Ming Lei
     [not found]                             ` <3535515.7NRjKhCcrL-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-12 15:29                               ` Alan Stern
2012-10-15 10:04                                 ` Oliver Neukum
     [not found]                                   ` <15188898.QK0YCDZ0MW-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-15 14:27                                     ` Alan Stern
2012-10-10  5:56         ` Ming Lei
     [not found]           ` <CACVXFVM7CrxXPYzr+dfWhbbmbF+3sXq4C1q2OauvP6x_jebbYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10  8:24             ` Oliver Neukum
2012-10-02  6:51   ` [PATCH 02/12] usbnet: asix: apply introduced usb command APIs Ming Lei
2012-10-02  6:51   ` [PATCH 07/12] usbnet: net1080: " Ming Lei
2012-10-02  6:51   ` [PATCH 08/12] usbnet: plusb: " Ming Lei
2012-10-02  6:51   ` [PATCH 11/12] usbnet: smsc95xx: " Ming Lei
2012-10-09  8:42   ` [PATCH 00/12] usbnet: usb_control_msg cleanup Oliver Neukum
2012-10-02  6:51 ` [PATCH 09/12] usbnet: sierra_net: apply introduced usb command APIs Ming Lei
2012-10-02  6:51 ` [PATCH 10/12] usbnet: smsc75xx: " Ming Lei
2012-10-02  6:51 ` [PATCH 12/12] usbnet: make device out of suspend before calling usbnet_read/write_cmd Ming Lei
2012-10-09  8:50   ` Oliver Neukum
     [not found]     ` <2913414.gCAxlQ38lG-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-10  2:33       ` Ming Lei
     [not found]         ` <CACVXFVNb-APsJG=ejW+2jqxTfAFsGhHovpgpsyvk6wUoKn5TzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10  5:34           ` Oliver Neukum
2012-10-10  6:00           ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349160684-6627-6-git-send-email-ming.lei@canonical.com \
    --to=ming.lei@canonical.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.