Re: [PATCH] cifs: reinstate the forcegid option

[Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Thu, 2012-10-04 at 18:46 +0530, Suresh Jayaraman wrote:
> On 10/04/2012 01:32 AM, Jeff Layton wrote:
> > Apparently this was lost when we converted to the standard option
> > parser.
> > 
> > Cc: Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > Reported-by: Gregory Lee Bartholomew <gregory.lee.bartholomew-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> 
> Oops, atleast a couple of options have been reported missing and fixed
> so far. Time to audit the new parsing code so that we fix them
> proactively before we get reports from users..?
> 

I am taking another look at the code to compare the options supported
against the old parser with the new parser. Some gotchas which tripped
me last time were checks for shortened options which also matched the
longer versions of the mount options.

We should also start thinking about paring down the number of mount
options which in my opinion are on the high side.

Sachin Prabhu