From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org,
"Bharat Bhushan" <Bharat.Bhushan@freescale.com>,
qemu-ppc@nongnu.org, "Avi Kivity" <avi@redhat.com>,
"Bharat Bhushan" <r65777@freescale.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 3/3] Adding BAR0 for e500 PCI controller
Date: Mon, 8 Oct 2012 15:23:52 -0500 [thread overview]
Message-ID: <1349727832.3721.3@snotra> (raw)
In-Reply-To: <841569A6-FF61-4AF0-91F5-7CF409E3314C@suse.de> (from agraf@suse.de on Mon Oct 8 14:04:43 2012)
On 10/08/2012 02:04:43 PM, Alexander Graf wrote:
>
> On 08.10.2012, at 20:00, Andreas Färber wrote:
>
> > Am 08.10.2012 18:46, schrieb Bharat Bhushan:
> >> #define BINARY_DEVICE_TREE_FILE "mpc8544ds.dtb"
> >> #define UIMAGE_LOAD_BASE 0
> >> -#define DTC_LOAD_PAD 0x1800000
> >> +#define DTC_LOAD_PAD 0x500000
> >> #define DTC_PAD_MASK 0xFFFFF
> >> #define INITRD_LOAD_PAD 0x2000000
> >> #define INITRD_PAD_MASK 0xFFFFFF
> >
> > Was this change intentional? I don't see it being used here, and
> commit
> > message doesn't seem to mention it.
>
> I'd assume he tried to work around a bug I fixed in between. But this
> change definitely is not intentional.
It looks like an accidental revert of
http://patchwork.ozlabs.org/patch/179475/
-Scott
next prev parent reply other threads:[~2012-10-08 20:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 16:46 [Qemu-devel] [PATCH 0/3] e500: creating CCSR region and registering bar0 Bharat Bhushan
2012-10-08 16:46 ` [Qemu-devel] [PATCH 1/3] e500: Fix serial initialization Bharat Bhushan
2012-10-08 17:00 ` Andreas Färber
2012-10-08 18:54 ` Alexander Graf
2012-10-08 16:46 ` [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region Bharat Bhushan
2012-10-08 17:21 ` Andreas Färber
2012-10-08 18:58 ` Alexander Graf
2012-10-09 17:23 ` Andreas Färber
2012-10-09 9:04 ` Avi Kivity
2012-10-09 16:45 ` Bhushan Bharat-R65777
2012-10-09 16:53 ` Avi Kivity
2012-10-09 16:57 ` Bhushan Bharat-R65777
2012-10-09 17:01 ` Avi Kivity
2012-10-09 17:05 ` Bhushan Bharat-R65777
2012-10-08 17:26 ` Andreas Färber
2012-10-08 16:46 ` [Qemu-devel] [PATCH 3/3] Adding BAR0 for e500 PCI controller Bharat Bhushan
2012-10-08 18:00 ` Andreas Färber
2012-10-08 19:04 ` Alexander Graf
2012-10-08 20:23 ` Scott Wood [this message]
2012-10-09 1:55 ` Bhushan Bharat-R65777
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349727832.3721.3@snotra \
--to=scottwood@freescale.com \
--cc=Bharat.Bhushan@freescale.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=r65777@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.