From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Ingo Molnar <mingo@kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH] task_work: avoid unneeded cmpxchg() in task_work_run()
Date: Tue, 09 Oct 2012 13:04:57 +0200 [thread overview]
Message-ID: <1349780697.7880.14.camel@twins> (raw)
In-Reply-To: <20121008123815.GA847@redhat.com>
On Mon, 2012-10-08 at 14:38 +0200, Oleg Nesterov wrote:
> But the code looks more complex, and the only advantage is that
> non-exiting task does xchg() instead of cmpxchg(). Not sure this
> worth the trouble, in this case task_work_run() will likey run
> the callbacks (the caller checks ->task_works != NULL), I do not
> think this can add any noticeable speedup.
Yeah, I agree, the patch doesn't seem worth the trouble. It makes tricky
code unreadable at best.
next prev parent reply other threads:[~2012-10-09 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 9:18 [PATCH] task_work: avoid unneeded cmpxchg() in task_work_run() Lai Jiangshan
2012-10-08 12:38 ` Oleg Nesterov
2012-10-09 11:04 ` Peter Zijlstra [this message]
2012-10-10 5:37 ` [PATCH V2] " Lai Jiangshan
2012-10-10 17:50 ` Oleg Nesterov
2012-10-10 17:50 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349780697.7880.14.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=edumazet@google.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.