All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] perl: fix @INC
Date: Tue, 09 Oct 2012 09:12:08 -0500	[thread overview]
Message-ID: <1349791928.19865.6.camel@empanada> (raw)
In-Reply-To: <1349788232.15658.173.camel@ted>

On Tue, 2012-10-09 at 14:10 +0100, Richard Purdie wrote:
> On Tue, 2012-10-09 at 16:32 +0800, Kang Kai wrote:
> > perl @INC path includes native perl modules path. When run "perl -V",
> > the output at the end is something like:
> >   @INC:
> >     /etc/perl
> >     /usr/lib/perl/site_perl/5.14.2/
> >     /usr/lib/perl/site_perl/5.14.2
> >     /usr/lib/perl/vendor_perl/5.14.2/
> >     /usr/lib/perl/vendor_perl/5.14.2
> >     /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
> >     /usr/lib/perl/5.14.2
> >     /usr/local/lib/site_perl
> >     /usr/lib/perl/5.14.2
> >     .
> > 
> > And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4.
> > Because the native path is compiled into libperl.so that sed in
> > perl_package_preprocess() could NOT remove it. So revert the commit.
> > 
> > [Yocto #3099]
> > 
> > Signed-off-by: Kang Kai <kai.kang@windriver.com>
> > ---
> >  meta/recipes-devtools/perl/perl-5.14.2/config.sh |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/recipes-devtools/perl/perl-5.14.2/config.sh b/meta/recipes-devtools/perl/perl-5.14.2/config.sh
> > index 0d4ca1c..dbfabb5 100644
> > --- a/meta/recipes-devtools/perl/perl-5.14.2/config.sh
> > +++ b/meta/recipes-devtools/perl/perl-5.14.2/config.sh
> > @@ -68,7 +68,7 @@ api_version='14'
> >  api_versionstring='5.14.0'
> >  ar='ar'
> >  archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
> > -archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
> > +archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi'
> >  archname64=''
> >  archname='@ARCH@-thread-multi'
> >  archobjs=''
> 
> I dislike fixing one bug at the expense of breaking another.
> 
> Tom,
> 
> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=aeca6512f3a5468b8f65e2986024ab07d2ce45b4
> 
> Any comments on this? How could we test the issue you originally fixed?
> 

The original purpose of that commit was to allow the perf build to use
ExtUtils::Embed to build the Perl language bindings for 'perf script'.

perl_package_preprocess() was (I thought) supposed to prevent the
settings in config.sh from making it to the target - I'll have to look
into why they do for libperl.so.

Tom

> Cheers,
> 
> Richard
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core





  reply	other threads:[~2012-10-09 14:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09  8:32 [PATCH 0/1] fix path in perl @INC Kang Kai
2012-10-09  8:32 ` [PATCH 1/1] perl: fix @INC Kang Kai
2012-10-09 13:10   ` Richard Purdie
2012-10-09 14:12     ` Tom Zanussi [this message]
2012-10-10  0:52       ` Tom Zanussi
2012-10-10  1:48         ` Kang Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349791928.19865.6.camel@empanada \
    --to=tom.zanussi@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.