From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1TLdWz-0004u8-DV
	for mharc-grub-devel@gnu.org; Tue, 09 Oct 2012 13:23:45 -0400
Received: from eggs.gnu.org ([208.118.235.92]:46770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1TLdWw-0004mg-S9
	for grub-devel@gnu.org; Tue, 09 Oct 2012 13:23:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1TLdWq-0007PD-UD
	for grub-devel@gnu.org; Tue, 09 Oct 2012 13:23:42 -0400
Received: from mail-lb0-f169.google.com ([209.85.217.169]:46945)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1TLdWq-0007On-N8
	for grub-devel@gnu.org; Tue, 09 Oct 2012 13:23:36 -0400
Received: by mail-lb0-f169.google.com with SMTP id k6so4204968lbo.0
	for <grub-devel@gnu.org>; Tue, 09 Oct 2012 10:23:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:subject:from:to:date:content-type:x-mailer:mime-version;
	bh=iZggKg8MTeuMl/I/Zmrt2sXf6V1MbuYPoz7oUXUxFWY=;
	b=MCF/bjfjGVGsCv5luaSS51G0HYqJVFQWSc85tqmoQjE+qYrV3Ap38q6pxHwu22XK0i
	YFN0RAQ8qDDI4+XOPSLsHtmcSG5TDEZ5PWeG53Z0VK/aWhjUGmMxL/Nh16rZ9heCRGVx
	5F8gmLnfpwYPYNGxTZU71dV68WAcwrhWMq6QMnXZKx8FIEybe5KuQtuCvjvpAgFgnk3d
	mO0x0PpQEKipGzEvjHqoXBA5a57wwFuC/lyp1gugs+LgOghaMH/RziL6Dd/C0wTs71A1
	1HIQghpz2aJVbH+DhaU6jOBJw/0wHb8YG0z9omgaY58RW95dGS2s0gY33SnTL6jNP7n6
	EiXA==
Received: by 10.112.25.168 with SMTP id d8mr8236261lbg.61.1349803415417;
	Tue, 09 Oct 2012 10:23:35 -0700 (PDT)
Received: from [192.168.10.142] (ppp83-237-35-0.pppoe.mtu-net.ru.
	[83.237.35.0])
	by mx.google.com with ESMTPS id c6sm6519283lbn.1.2012.10.09.10.23.33
	(version=SSLv3 cipher=OTHER); Tue, 09 Oct 2012 10:23:34 -0700 (PDT)
Message-ID: <1349803412.1698.4.camel@opensuse.site>
Subject: [PATCH] remove obsolete TODO from grub-install
From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Date: Tue, 09 Oct 2012 21:23:32 +0400
Content-Type: multipart/mixed; boundary="=-dcHJv3V3t7wJ77mGowgP"
X-Mailer: Evolution 3.4.4 
Mime-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.217.169
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Oct 2012 17:23:44 -0000


--=-dcHJv3V3t7wJ77mGowgP
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

It does use efibootmgr, so TODO is misleading.



--=-dcHJv3V3t7wJ77mGowgP
Content-Disposition: attachment; filename="grub-install-does-use-efibootmgr.patch"
Content-Type: text/x-patch; name="grub-install-does-use-efibootmgr.patch";
	charset="UTF-8"
Content-Transfer-Encoding: 7bit

=== modified file 'util/grub-install.in'
--- util/grub-install.in	2012-09-24 17:50:35 +0000
+++ util/grub-install.in	2012-10-09 17:15:52 +0000
@@ -486,8 +486,6 @@
 		*)
 		    efi_file=grub.efi ;;
 	    esac
-	   # TODO: We should also use efibootmgr, if available, to add a Boot
-	   # entry for ourselves.
 	fi
 	efidir="$efidir/EFI/$efi_distributor"
 	mkdir -p "$efidir" || exit 1


--=-dcHJv3V3t7wJ77mGowgP--