From: Tom Zanussi <tom.zanussi@intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/2] perl: fix @INC, v2
Date: Wed, 10 Oct 2012 09:27:39 -0500 [thread overview]
Message-ID: <1349879259.19865.42.camel@empanada> (raw)
In-Reply-To: <1349878484.15658.220.camel@ted>
On Wed, 2012-10-10 at 15:14 +0100, Richard Purdie wrote:
> On Tue, 2012-10-09 at 19:48 -0500, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> >
> > This fixes the bug reported by Kang Kai in a way that allows
> > perf scripting to continue to work.
> >
> > Before this patch, @INC on the target would contain a native path:
> >
> > @INC:
> > /etc/perl
> > /usr/lib/perl/site_perl/5.14.2/
> > /usr/lib/perl/site_perl/5.14.2
> > /usr/lib/perl/vendor_perl/5.14.2/
> > /usr/lib/perl/vendor_perl/5.14.2
> > /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
> > /usr/lib/perl/5.14.2
> > /usr/local/lib/site_perl
> > /usr/lib/perl/5.14.2
> > .
> >
> > Kang Kai's patch reverted the problem that caused the native path
> > to appear, but also caused perf to report that scripting wasn't
> > supported.
> >
> > With this patchset, the native path is gone:
> >
> > Built under linux
> > Compiled at Oct 9 2012 18:40:15
> > @INC:
> > /etc/perl
> > /usr/lib/perl/site_perl/5.14.2/
> > /usr/lib/perl/site_perl/5.14.2
> > /usr/lib/perl/vendor_perl/5.14.2/
> > /usr/lib/perl/vendor_perl/5.14.2
> > /usr/lib/perl/5.14.2/
> > /usr/lib/perl/5.14.2
> > /usr/local/lib/site_perl
> > /usr/lib/perl/5.14.2
> > .
> >
> > and the perf Perl binding continues to work:
> >
> > root@crownbay:~# perf script rwtop
> >
> > read counts by pid:
> >
> > pid comm # reads bytes_req bytes_read
> > ------ -------------------- ---------- ---------- ----------
> > 1524 perf 5629 213712 213648
> > 1508 dropbear 8 131000 607
> >
> > write counts by pid:
> >
> > pid comm # writes bytes_written
> > ------ -------------------- ---------- -------------
> > 1522 perf 11 845320
> > 1508 dropbear 8 944
> >
> > Tested on qemux86 and crownbay.
> >
> > The following changes since commit 2c3e8280e67721d42d4be48a8e2c1e9ce9bb89fd:
> >
> > bitbake: hob/imageconfigurationpage: a 'hob-image' appears listed in the base image combo box (2012-10-08 16:23:34 +0100)
> >
> > are available in the git repository at:
> >
> > git://git.yoctoproject.org/poky-contrib.git tzanussi/bug-3099-fix
> > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/bug-3099-fix
> >
> > Tom Zanussi (2):
> > perl: add archlib_exp variable used to generate ARCHLIB_EXP in
> > config.h
> > perl: use archlib_exp config.sh variable
>
> I've taken these but I didn't like them being two commits, or the lack
> of information in the patch header. I therefore tweaked it before
> applying.
>
OK, thanks, sorry to miss those things, will keep it in mind for next
time...
Tom
> Cheers,
>
> Richard
>
prev parent reply other threads:[~2012-10-10 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 0:48 [PATCH 0/2] perl: fix @INC, v2 tom.zanussi
2012-10-10 0:48 ` [PATCH 1/2] perl: add archlib_exp variable used to generate ARCHLIB_EXP in config.h tom.zanussi
2012-10-10 0:48 ` [PATCH 2/2] perl: use archlib_exp config.sh variable tom.zanussi
2012-10-10 3:00 ` Kang Kai
2012-10-10 3:24 ` Tom Zanussi
2012-10-10 14:14 ` [PATCH 0/2] perl: fix @INC, v2 Richard Purdie
2012-10-10 14:27 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349879259.19865.42.camel@empanada \
--to=tom.zanussi@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.