From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cHlTC-0001eO-5S for ath10k@lists.infradead.org; Fri, 16 Dec 2016 05:54:15 +0000 MIME-Version: 1.0 Date: Fri, 16 Dec 2016 11:23:52 +0530 From: Tamizh chelvam Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX In-Reply-To: <1481645351.20412.34.camel@sipsolutions.net> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> Message-ID: <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org SGkgSm9oYW5uZXMsCgpUaGFua3MgZm9yIHRoZSBjb21tZW50cwoKT24gMjAxNi0xMi0xMyAyMToz OSwgSm9oYW5uZXMgQmVyZyB3cm90ZToKPj4gPiA+IMKgLyoqCj4+ID4gPiArICogd2lwaHlfYnRj b2V4X3N1cHBvcnRfZmxhZ3MKPj4gPiA+ICsgKglUaGlzIGVudW0gaGFzIHRoZSBkcml2ZXIgc3Vw cG9ydGVkIGZyYW1lIHR5cGVzIGZvcgo+PiA+ID4gQlRDT0VYLgo+PiA+ID4gKyAqIEBXSVBIWV9X TEFOX0JFX1BSRUZFUlJFRCAtIFN1cHBvcnRzIEJlc3QgRWZmb3J0IGZyYW1lIGZvcgo+PiA+ID4g QlRDT0VYCj4+ID4gPiArICogQFdJUEhZX1dMQU5fQktfUFJFRkVSUkVEIC0gc3VwcG9ydHMgQmFj a2dyb3VuZCBmcmFtZSBmb3IKPj4gPiA+IEJUQ09FWAo+PiA+ID4gKyAqIEBXSVBIWV9XTEFOX1ZJ X1BSRUZFUlJFRCAtIHN1cHBvcnRzIFZpZGVvIGZyYW1lIGZvciBCVENPRVgKPj4gPiA+ICsgKiBA V0lQSFlfV0xBTl9WT19QUkVGRVJSRUQgLSBzdXBwb3J0cyBWb2ljZSBmcmFtZSBmb3IgQlRDT0VY Cj4+ID4gPiArICogQFdJUEhZX1dMQU5fQkVBQ09OX1BSRUZFUlJFRCAtIHN1cHBvcnRzIEJlYWNv biBmcmFtZSBmb3IKPj4gPiA+IEJUQ09FWAo+PiA+ID4gKyAqIEBXSVBIWV9XTEFOX01HTVRfUFJF RkVSUkVEIC0gc3VwcG9ydHMgTWFuYWdlbWVudCBmcmFtZXMgZm9yCj4+ID4gPiBCVENPRVguCj4+ ID4gPiArICovCj4+ID4KPj4gPiBUaGF0J3Mgbm90IG1ha2luZyBtdWNoIHNlbnNlIHRvIG1lPwo+ PiA+Cj4+IAo+PiBpcyBpdCBmaW5lIHRvIGhhdmUgYXMgV0lQSFlfQlRDT0VYX0JFX1BSRUZFUlJF RCA/Cj4gCj4gSXQncyBub3QgcmVhbGx5IGNsZWFyIHRvIG1lIHdoYXQgeW91IGludGVuZCB0byBk byB0aGlzIC0gaWYgaXQncyByZWFsbHkKPiBzdXBwb3J0IGZsYWdzIHRoZW4geW91IHJlYWxseSBz aG91bGQgbmFtZSB0aG9zZSBiZXR0ZXIuCj4gClRoaXMgaXMgc3VwcG9ydCBmbGFncyBhbmQgaXQg dXNlZCBieSB0aGUgZHJpdmVyIHRvIGludGltYXRlIGRyaXZlciAKc3VwcG9ydGVkIGZyYW1lIHR5 cGUKZm9yIHRoZSBCVENPRVggdG8gY2ZnIGxpa2UgIndpcGh5X3dvd2xhbl9zdXBwb3J0X2ZsYWdz IiBpbXBsZW1lbnRhdGlvbi4KUGxlYXNlIHN1Z2dlc3QgaWYgdGhpcyBpcyBvayA/IEkgd2lsbCBi ZSB0aGFua2Z1bCBpZiB5b3UgY2FuIHN1Z2dlc3QgYSAKYmV0dGVyIG9uZSBpZiB0aGlzIGlzIG5v dCBvawoiV0lQSFlfQlRDT0VYX1NVUFBPUlRTX0JFIgoKPj4gPiA+ICsvKioKPj4gPiA+ICsgKiBl bnVtIHdpcGh5X2J0Y29leF9wcmlvcml0eSAtIEJUQ09FWCBwcmlvcml0eSBsZXZlbAo+PiA+ID4g KyAqCVRoaXMgZW51bSBkZWZpbmVzIHByaW9yaXR5IGxldmVsIGZvciBCVENPRVgKPj4gPiA+ICsg KiBXSVBIWV9XTEFOX1BSRUZFUlJFRF9MT1cgLSBsb3cgcHJpb3JpdHkgZnJhbWVzIG92ZXIgQlQK Pj4gPiA+IHRyYWZmaWMKPj4gPiA+ICsgKiBXSVBIWV9XTEFOX1BSRUZFUlJFRF9ISUdIIC0gaGln aCBwcmlvcml0eSBmcmFtZXMgb3ZlciBCVAo+PiA+ID4gdHJhZmZpYwo+PiA+ID4gKyAqLwo+PiA+ ID4gKwo+PiA+ID4gK2VudW0gd2lwaHlfYnRjb2V4X3ByaW9yaXR5IHsKPj4gPiA+ICsJV0lQSFlf V0xBTl9QUkVGRVJSRURfTE9XID0gZmFsc2UsCj4+ID4gPiArCVdJUEhZX1dMQU5fUFJFRkVSUkVE X0hJR0ggPSB0cnVlLAo+PiA+ID4gK307Cj4+ID4KPj4gPiBUaGF0IGZhbHNlL3RydWUgc2VlbXMg anVzdCBzdHJhbmdlLgo+PiA+Cj4+IAo+PiBJIHdpbGwganVzdCB1c2UgYXMgYSBlbnVtIHdpdGhv dXQgYXNzaWduaW5nIGZhbHNlL3RydWUuCj4gCj4gV2hhdCBkbyB5b3UgZXZlbiBuZWVkIHRoaXMg ZW51bSBmb3IgdGhvdWdoPwo+IApPay4gSSB3aWxsIGRpcmVjdGx5IGFzc2lnbiB0cnVlIGZvciB0 aGUgZmxhZy4KCj4+ID4gPiArZW51bSBubDgwMjExX2J0Y29leF9wcmlvcml0eSB7Cj4+ID4gPiAr CV9fTkw4MDIxMV9XTEFOX1BSRUZFUlJFRF9JTlZBTElELAo+PiA+ID4gKwlOTDgwMjExX1dMQU5f QkVfUFJFRkVSUkVELAo+PiA+ID4gKwlOTDgwMjExX1dMQU5fQktfUFJFRkVSUkVELAo+PiA+ID4g KwlOTDgwMjExX1dMQU5fVklfUFJFRkVSUkVELAo+PiA+ID4gKwlOTDgwMjExX1dMQU5fVk9fUFJF RkVSUkVELAo+PiA+ID4gKwlOTDgwMjExX1dMQU5fQkVBQ09OX1BSRUZFUlJFRCwKPj4gPiA+ICsJ Tkw4MDIxMV9XTEFOX01HTVRfUFJFRkVSUkVELAo+PiA+ID4gKwlfX05MODAyMTFfV0xBTl9QUkVG RVJSRURfTEFTVCwKPj4gPiA+ICsJTkw4MDIxMV9XTEFOX1BSRUZFUlJFRF9NQVggPQo+PiA+ID4g KwkJCV9fTkw4MDIxMV9XTEFOX1BSRUZFUlJFRF9MQVNUIC0gMSwKPj4gPiA+ICt9Owo+PiA+Cj4+ ID4gV291bGRuJ3QgYSBiaXRtYXAgYmUgZWFzaWVyPwo+PiA+Cj4+IHNpbmNlIHRoaXMgaXMgdG8g ZGlzdGluZ3Vpc2ggYmV0d2VlbiBkaWZmZXJlbnQgYnRjb2V4IHByaW9yaXRpZXMgYW5kCj4+IHdl wqAKPj4gYXJlIG5vdCBnb2luZyB0byBkbyBhbnkgbWFuaXB1bGF0aW9ucyBvbiB0aGVzZSBwYXJh bWV0ZXJzLgo+PiBJdCBpcyBqdXN0IHVzZWQgYXMgZmxhZyBhdHRyaWJ1dGUuCj4gCj4gQnV0IHdo eSB0aGUgKHBhcnNpbmcpIGNvbXBsZXhpdHksIHdoZW4gYSBzaW5nbGUgYml0bWFwIHdvdWxkIGRv Pwo+IApEbyB5b3UgbWVhbiB0byBzYXksIHNlbmRpbmcgYSB2YWx1ZSBmcm9tIHVzZXIgc3BhY2Ug YW5kIHBhcnNlIHRoYXQgaW4gCnRoZSBkcml2ZXI/CgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:40408 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509AbcLPFzC (ORCPT ); Fri, 16 Dec 2016 00:55:02 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Fri, 16 Dec 2016 11:23:52 +0530 From: Tamizh chelvam To: Johannes Berg Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX In-Reply-To: <1481645351.20412.34.camel@sipsolutions.net> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> Message-ID: <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> (sfid-20161216_065617_263612_A0092E8B) Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Johannes, Thanks for the comments On 2016-12-13 21:39, Johannes Berg wrote: >> > >  /** >> > > + * wiphy_btcoex_support_flags >> > > + * This enum has the driver supported frame types for >> > > BTCOEX. >> > > + * @WIPHY_WLAN_BE_PREFERRED - Supports Best Effort frame for >> > > BTCOEX >> > > + * @WIPHY_WLAN_BK_PREFERRED - supports Background frame for >> > > BTCOEX >> > > + * @WIPHY_WLAN_VI_PREFERRED - supports Video frame for BTCOEX >> > > + * @WIPHY_WLAN_VO_PREFERRED - supports Voice frame for BTCOEX >> > > + * @WIPHY_WLAN_BEACON_PREFERRED - supports Beacon frame for >> > > BTCOEX >> > > + * @WIPHY_WLAN_MGMT_PREFERRED - supports Management frames for >> > > BTCOEX. >> > > + */ >> > >> > That's not making much sense to me? >> > >> >> is it fine to have as WIPHY_BTCOEX_BE_PREFERRED ? > > It's not really clear to me what you intend to do this - if it's really > support flags then you really should name those better. > This is support flags and it used by the driver to intimate driver supported frame type for the BTCOEX to cfg like "wiphy_wowlan_support_flags" implementation. Please suggest if this is ok ? I will be thankful if you can suggest a better one if this is not ok "WIPHY_BTCOEX_SUPPORTS_BE" >> > > +/** >> > > + * enum wiphy_btcoex_priority - BTCOEX priority level >> > > + * This enum defines priority level for BTCOEX >> > > + * WIPHY_WLAN_PREFERRED_LOW - low priority frames over BT >> > > traffic >> > > + * WIPHY_WLAN_PREFERRED_HIGH - high priority frames over BT >> > > traffic >> > > + */ >> > > + >> > > +enum wiphy_btcoex_priority { >> > > + WIPHY_WLAN_PREFERRED_LOW = false, >> > > + WIPHY_WLAN_PREFERRED_HIGH = true, >> > > +}; >> > >> > That false/true seems just strange. >> > >> >> I will just use as a enum without assigning false/true. > > What do you even need this enum for though? > Ok. I will directly assign true for the flag. >> > > +enum nl80211_btcoex_priority { >> > > + __NL80211_WLAN_PREFERRED_INVALID, >> > > + NL80211_WLAN_BE_PREFERRED, >> > > + NL80211_WLAN_BK_PREFERRED, >> > > + NL80211_WLAN_VI_PREFERRED, >> > > + NL80211_WLAN_VO_PREFERRED, >> > > + NL80211_WLAN_BEACON_PREFERRED, >> > > + NL80211_WLAN_MGMT_PREFERRED, >> > > + __NL80211_WLAN_PREFERRED_LAST, >> > > + NL80211_WLAN_PREFERRED_MAX = >> > > + __NL80211_WLAN_PREFERRED_LAST - 1, >> > > +}; >> > >> > Wouldn't a bitmap be easier? >> > >> since this is to distinguish between different btcoex priorities and >> we  >> are not going to do any manipulations on these parameters. >> It is just used as flag attribute. > > But why the (parsing) complexity, when a single bitmap would do? > Do you mean to say, sending a value from user space and parse that in the driver?