From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1350085760.19673.9.camel@aeonflux> Subject: Re: [RFCv1 1/7] Bluetooth: AMP: Use Loglink handle in ACL Handle field From: Marcel Holtmann To: Andrei Emeltchenko Cc: linux-bluetooth@vger.kernel.org Date: Sat, 13 Oct 2012 01:49:20 +0200 In-Reply-To: <1350051005-6015-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> References: <1350051005-6015-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrei, > For AMP HCI controller use Logical Link handle in HCI ACL > Handle field. > > Signed-off-by: Andrei Emeltchenko > --- > net/bluetooth/hci_core.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) Acked-by: Marcel Holtmann > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c > index 2e72c41..32c4dbe 100644 > --- a/net/bluetooth/hci_core.c > +++ b/net/bluetooth/hci_core.c > @@ -2162,7 +2162,20 @@ static void hci_queue_acl(struct hci_chan *chan, struct sk_buff_head *queue, > skb->data_len = 0; > > bt_cb(skb)->pkt_type = HCI_ACLDATA_PKT; > - hci_add_acl_hdr(skb, conn->handle, flags); > + > + switch (hdev->dev_type) { > + case HCI_BREDR: > + hci_add_acl_hdr(skb, conn->handle, flags); > + break; > + However, remove the empty lines here. It is fine to condense this statement since they are single statements. > + case HCI_AMP: > + hci_add_acl_hdr(skb, chan->handle, flags); > + break; > + > + default: > + BT_ERR("%s unknown dev_type %d", hdev->name, hdev->dev_type); > + return; > + } > > list = skb_shinfo(skb)->frag_list; > if (!list) { regards Marcel