From: Sangho Yi <antiroot@gmail.com>
To: devel@driverdev.osuosl.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Sangho Yi <antiroot@gmail.com>
Subject: [PATCH 1/4] Drivers: Staging: CSR: Fixed indentation problems on data_tx.c
Date: Mon, 15 Oct 2012 00:16:50 +0900 [thread overview]
Message-ID: <1350227813-30880-1-git-send-email-antiroot@gmail.com> (raw)
In-Reply-To: <n>
Originally, the data_tx.c was indented with 4 spaces, so I fixed the
indentation using a single tab.
Signed-off-by: Sangho Yi <antiroot@gmail.com>
---
drivers/staging/csr/data_tx.c | 58 ++++++++++++++++++++---------------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/csr/data_tx.c b/drivers/staging/csr/data_tx.c
index 8ed7a78..8af0358 100644
--- a/drivers/staging/csr/data_tx.c
+++ b/drivers/staging/csr/data_tx.c
@@ -15,36 +15,37 @@
#include "csr_wifi_hip_unifi.h"
#include "unifi_priv.h"
-int
-uf_verify_m4(unifi_priv_t *priv, const unsigned char *packet, unsigned int length)
-{
- const unsigned char *p = packet;
- u16 keyinfo;
+int uf_verify_m4 (unifi_priv_t *priv, const unsigned char *packet,
+ unsigned int length) {
+ const unsigned char *p = packet;
+ u16 keyinfo;
+ if (length < (4 + 5 + 8 + 32 + 16 + 8 + 8 + 16 + 1 + 8)) {
+ return 1;
+ }
- if (length < (4 + 5 + 8 + 32 + 16 + 8 + 8 + 16 + 1 + 8)) {
- return 1;
- }
-
- p += 8;
- keyinfo = p[5] << 8 | p[6]; /* big-endian */
- if (
- (p[0] == 1 || p[0] == 2) /* protocol version 802.1X-2001 (WPA) or -2004 (WPA2) */ &&
- p[1] == 3 /* EAPOL-Key */ &&
- /* don't bother checking p[2] p[3] (hh ll, packet body length) */
- (p[4] == 254 || p[4] == 2) /* descriptor type P802.1i-D3.0 (WPA) or 802.11i-2004 (WPA2) */ &&
- ((keyinfo & 0x0007) == 1 || (keyinfo & 0x0007) == 2) /* key descriptor version */ &&
- (keyinfo & ~0x0207U) == 0x0108 && /* key info for 4/4 or 4/2 -- ignore key desc version and sec bit (since varies in WPA 4/4) */
- (p[4 + 5 + 8 + 32 + 16 + 8 + 8 + 16 + 0] == 0 && /* key data length (2 octets) 0 for 4/4 only */
- p[4 + 5 + 8 + 32 + 16 + 8 + 8 + 16 + 1] == 0)
- ) {
- unifi_trace(priv, UDBG1, "uf_verify_m4: M4 detected \n");
- return 0;
- }
- else
- {
- return 1;
- }
+ p += 8;
+ keyinfo = p[5] << 8 | p[6]; /* big-endian */
+ if ((p[0] == 1 || p[0] == 2) &&
+ /* protocol version 802.1X-2001 (WPA) or -2004 (WPA2) */
+ p[1] == 3 && /* EAPOL-Key */
+ /* don't bother checking p[2] p[3]
+ * (hh ll, packet body length) */
+ (p[4] == 254 || p[4] == 2) &&
+ /* descriptor type P802.1i-D3.0 (WPA) or 802.11i-2004 (WPA2) */
+ ((keyinfo & 0x0007) == 1 || (keyinfo & 0x0007) == 2) &&
+ /* key descriptor version */
+ ((keyinfo & ~0x0207U) == 0x0108) &&
+ /* key info for 4/4 or 4/2 -- ignore key desc version and
+ * sec bit (since varies in WPA 4/4) */
+ ((p[4 + 5 + 8 + 32 + 16 + 8 + 8 + 16 + 0] == 0) &&
+ /* key data length (2 octets) 0 for 4/4 only */
+ p[4 + 5 + 8 + 32 + 16 + 8 + 8 + 16 + 1] == 0)) {
+ unifi_trace(priv, UDBG1, "uf_verify_m4: M4 detected \n");
+ return 0;
+ } else {
+ return 1;
+ }
}
/*
@@ -54,4 +55,3 @@ uf_verify_m4(unifi_priv_t *priv, const unsigned char *packet, unsigned int lengt
*
* ---------------------------------------------------------------------------
*/
-
--
1.7.9.5
next reply other threads:[~2012-10-14 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 15:16 Sangho Yi [this message]
2012-10-14 15:16 ` [PATCH 2/4] Drivers: Staging: CSR: Removed braces for single line if statement Sangho Yi
2012-10-22 21:02 ` Greg KH
2012-10-14 15:16 ` [PATCH 3/4] Drivers: Staging: CSR: Removed whitespace between function name and ( Sangho Yi
2012-10-22 21:02 ` Greg KH
2012-10-14 15:16 ` [PATCH 4/4] Drivers: Staging: CSR: Removed whitespace before quoting newline Sangho Yi
2012-10-22 21:03 ` Greg KH
2012-10-18 13:31 ` [PATCH 1/4] Drivers: Staging: CSR: Fixed indentation problems on data_tx.c Dan Carpenter
2012-10-22 21:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350227813-30880-1-git-send-email-antiroot@gmail.com \
--to=antiroot@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.