All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
	viresh kumar <viresh.kumar@linaro.org>,
	spear-devel <spear-devel@list.st.com>,
	Vipin Kumar <vipin.kumar@st.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	"plagnioj@jcrosoft.com" <plagnioj@jcrosoft.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 07/11] fsmc/nand: Provide contiguous buffers to dma
Date: Tue, 16 Oct 2012 10:14:45 +0300	[thread overview]
Message-ID: <1350371685.5769.45.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <CACRpkdao_9TkH7=ia7kXB-KsQhNZQ7EfSS5B1X0wFPgg5OsuHA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

On Mon, 2012-10-15 at 21:51 +0200, Linus Walleij wrote:
> On Mon, Oct 15, 2012 at 6:27 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> 
> > I would prefer not building a solution that hopes kmalloc() can get a
> > large contiguous buffer (remember, eraseblock sizes come as large as
> > 2MB these days). A real solution like CMA or scatter-gather seems like
> > a better idea.
> 
> +1 on that, and as I think I illustrated the MMC subsystem is using
> the block layer helpers to form scatter-gather lists for it's requests.
> I don't see why the MTD subsystem need to be very different?

This is good idea, the problem is that it is a bit more work than
hacking the driver, so most people prefer the latter. By removing all
kmalloc()'s I basically wish to force people to go this way.

What are the SC functions names you refer?

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/11] fsmc/nand: Provide contiguous buffers to dma
Date: Tue, 16 Oct 2012 10:14:45 +0300	[thread overview]
Message-ID: <1350371685.5769.45.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <CACRpkdao_9TkH7=ia7kXB-KsQhNZQ7EfSS5B1X0wFPgg5OsuHA@mail.gmail.com>

On Mon, 2012-10-15 at 21:51 +0200, Linus Walleij wrote:
> On Mon, Oct 15, 2012 at 6:27 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> 
> > I would prefer not building a solution that hopes kmalloc() can get a
> > large contiguous buffer (remember, eraseblock sizes come as large as
> > 2MB these days). A real solution like CMA or scatter-gather seems like
> > a better idea.
> 
> +1 on that, and as I think I illustrated the MMC subsystem is using
> the block layer helpers to form scatter-gather lists for it's requests.
> I don't see why the MTD subsystem need to be very different?

This is good idea, the problem is that it is a bit more work than
hacking the driver, so most people prefer the latter. By removing all
kmalloc()'s I basically wish to force people to go this way.

What are the SC functions names you refer?

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121016/e67d78eb/attachment-0001.sig>

  reply	other threads:[~2012-10-16  7:14 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09 10:44 [PATCH 00/11] mtd/nand: fsmc driver updates Vipin Kumar
2012-10-09 10:44 ` Vipin Kumar
2012-10-09 10:44 ` [PATCH 01/11] fsmc/nand:FIX: Change the type for regs to void __iomem * Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-09 17:14   ` viresh kumar
2012-10-09 17:14     ` viresh kumar
2012-10-10 16:49   ` Linus Walleij
2012-10-10 16:49     ` Linus Walleij
2012-10-17 12:30   ` Artem Bityutskiy
2012-10-17 12:30     ` Artem Bityutskiy
2012-10-09 10:44 ` [PATCH 02/11] fsmc/nand: Rearrange the fsmc_nand_data structure and update comments Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-09 11:52   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 11:52     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-11  4:24     ` Vipin Kumar
2012-10-11  4:24       ` Vipin Kumar
2012-10-09 17:15   ` viresh kumar
2012-10-09 17:15     ` viresh kumar
2012-10-09 10:44 ` [PATCH 03/11] fsmc/nand: Support multiple banks connected to controller Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-09 11:55   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 11:55     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-10 10:28     ` Vipin Kumar
2012-10-10 10:28       ` Vipin Kumar
2012-10-17 12:31   ` Artem Bityutskiy
2012-10-17 12:31     ` Artem Bityutskiy
2012-10-09 10:44 ` [PATCH 04/11] fsmc/nand: Accept nand timing parameters via DT Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-09 11:57   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 11:57     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-11  4:25     ` Vipin Kumar
2012-10-11  4:25       ` Vipin Kumar
2012-10-09 17:20   ` viresh kumar
2012-10-09 17:20     ` viresh kumar
2012-10-09 10:44 ` [PATCH 05/11] fsmc: Implement ready/busy through gpio pin Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-09 11:59   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 11:59     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 17:34   ` viresh kumar
2012-10-09 17:34     ` viresh kumar
2012-10-09 10:44 ` [PATCH 06/11] fsmc/nand: Modify the wait to uninterruptible Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-10 17:10   ` Linus Walleij
2012-10-10 17:10     ` Linus Walleij
2012-10-17 12:47   ` Artem Bityutskiy
2012-10-17 12:47     ` Artem Bityutskiy
2012-10-09 10:44 ` [PATCH 07/11] fsmc/nand: Provide contiguous buffers to dma Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-09 17:41   ` viresh kumar
2012-10-09 17:41     ` viresh kumar
2012-10-10 17:07   ` Linus Walleij
2012-10-10 17:07     ` Linus Walleij
2012-10-11  3:16     ` viresh kumar
2012-10-11  3:16       ` viresh kumar
2012-10-11  4:07       ` Vipin Kumar
2012-10-11  4:07         ` Vipin Kumar
2012-10-11  4:08     ` Vipin Kumar
2012-10-11  4:08       ` Vipin Kumar
2012-10-11  4:15     ` viresh kumar
2012-10-11  4:15       ` viresh kumar
2012-10-11 16:06       ` Linus Walleij
2012-10-11 16:06         ` Linus Walleij
2012-10-11 17:07         ` viresh kumar
2012-10-11 17:07           ` viresh kumar
2012-10-11 21:51           ` Linus Walleij
2012-10-11 21:51             ` Linus Walleij
2012-10-12  3:55         ` Vipin Kumar
2012-10-12  3:55           ` Vipin Kumar
2012-10-15 13:18           ` Artem Bityutskiy
2012-10-15 13:18             ` Artem Bityutskiy
2012-10-15 16:27             ` Brian Norris
2012-10-15 16:27               ` Brian Norris
2012-10-15 19:51               ` Linus Walleij
2012-10-15 19:51                 ` Linus Walleij
2012-10-16  7:14                 ` Artem Bityutskiy [this message]
2012-10-16  7:14                   ` Artem Bityutskiy
2012-10-16 10:05                   ` Linus Walleij
2012-10-16 10:05                     ` Linus Walleij
2012-10-21  7:38                     ` Brian Norris
2012-10-21  7:38                       ` Brian Norris
2012-10-21 11:00                       ` Artem Bityutskiy
2012-10-21 11:00                         ` Artem Bityutskiy
2012-10-21 12:02                         ` Artem Bityutskiy
2012-10-21 12:02                           ` Artem Bityutskiy
2012-10-16  7:11               ` Artem Bityutskiy
2012-10-16  7:11                 ` Artem Bityutskiy
2012-10-21  7:21                 ` Brian Norris
2012-10-21  7:21                   ` Brian Norris
2012-10-09 10:44 ` [PATCH 08/11] fsmc/nand: Use relaxed variants of io accessors Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-09 17:42   ` viresh kumar
2012-10-09 17:42     ` viresh kumar
2012-10-10 17:09   ` Linus Walleij
2012-10-10 17:09     ` Linus Walleij
2012-10-09 10:44 ` [PATCH 09/11] fsmc/nand:FIX: replace change_bit routine Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-10 17:22   ` Linus Walleij
2012-10-10 17:22     ` Linus Walleij
2012-10-10 20:21     ` Nicolas Pitre
2012-10-10 20:21       ` Nicolas Pitre
2012-10-11  4:17       ` Vipin Kumar
2012-10-11  4:17         ` Vipin Kumar
2012-10-10 20:45     ` Russell King - ARM Linux
2012-10-10 20:45       ` Russell King - ARM Linux
2012-10-11  4:20       ` Vipin Kumar
2012-10-11  4:20         ` Vipin Kumar
2012-10-09 10:44 ` [PATCH 10/11] fsmc/nand: Add sw bch support for ecc calculation/correction Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-09 11:50   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09 11:50     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-10 10:33     ` Vipin Kumar
2012-10-10 10:33       ` Vipin Kumar
2012-10-09 10:44 ` [PATCH 11/11] nand: Increase the ecc placement locations to 640 Vipin Kumar
2012-10-09 10:44   ` Vipin Kumar
2012-10-17 12:47   ` Artem Bityutskiy
2012-10-17 12:47     ` Artem Bityutskiy
2012-10-18  6:36   ` Brian Norris
2012-10-18  6:36     ` Brian Norris
2012-10-17 12:48 ` [PATCH 00/11] mtd/nand: fsmc driver updates Artem Bityutskiy
2012-10-17 12:48   ` Artem Bityutskiy
2012-10-18  4:13   ` Vipin Kumar
2012-10-18  4:13     ` Vipin Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350371685.5769.45.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=spear-devel@list.st.com \
    --cc=vinod.koul@intel.com \
    --cc=vipin.kumar@st.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.