From: Richard Purdie <richard.purdie@intel.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] nativesdk-perl: fix dependecy
Date: Wed, 17 Oct 2012 17:20:44 +0100 [thread overview]
Message-ID: <1350490844.2185.119.camel@ted> (raw)
In-Reply-To: <507D17CA.9060309@windriver.com>
On Tue, 2012-10-16 at 16:16 +0800, Robert Yang wrote:
> Hi Richard,
>
> Here are more details for this problem:
>
> RRECOMMENDS_perl-modules = "${@d.getVar('PACKAGES', True)...}"
>
> The PACKAGES would be reset by do_split_packages since:
>
> PACKAGES_DYNAMIC = "perl-module-*"
> PACKAGES_DYNAMIC_virtclass-nativesdk = "nativesdk-perl-module-*"
>
> Then:
> 1) The target perl-modules RRECOMMENDS on perl-module-*, this is what
> we expect.
>
> 2) But the nativesdk-perl-modules doesn't RRECOMMENDS on
> nativesdk-perl-module-*, this is not what we expect.
>
> I have checked the value of PACKAGES after do_split_packages, it has been
> set correctly (it contains the nativesdk-perl-module-* packages)
>
> But the:
>
> RRECOMMENDS_perl-modules = "${@d.getVar('PACKAGES', True)...}"
>
> doesn't work correctly for nativesdk, the d.getVar('RRECOMMENDS_perl-modules',
> True) doesn't get the new value of the PACKAGES, it gets the value of PACKAGES
> before the do_split_packages.
>
> The current patch would fix the problem, but I don't know the root cause,
> do you have any comments or directions, please?
The root cause is the way the class extension code works. I think in
this case, moving the setting of the RRECOMMENDS_perl-modules to where
you set it is the correct thing to do. We need to include this
explanation in the patch/commit though.
Cheers,
Richard
next prev parent reply other threads:[~2012-10-17 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 11:32 [PATCH 0/2] Fix nativesdk-perl dependency Kang Kai
2012-10-15 11:32 ` [PATCH 1/2] nativesdk-perl: fix dependecy Kang Kai
2012-10-16 8:16 ` Robert Yang
2012-10-17 16:20 ` Richard Purdie [this message]
2012-10-15 11:32 ` [PATCH 2/2] nativesdk-packagegroup-sdk-host: add perl modules Kang Kai
2012-10-15 20:55 ` Richard Purdie
2012-10-16 1:59 ` Kang Kai
2012-10-17 16:22 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350490844.2185.119.camel@ted \
--to=richard.purdie@intel.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.