From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Robert Berger <robert.karl.berger@gmail.com>
Cc: linuxppc-dev@ozlabs.org, wd@denx.de, mla@apm.com
Subject: Re: ELDK 4.2/kilauea/3.5+ kernel broken
Date: Fri, 19 Oct 2012 06:03:26 +1100 [thread overview]
Message-ID: <1350587006.2476.12.camel@pasglop> (raw)
In-Reply-To: <50804020.30505@gmail.com>
On Thu, 2012-10-18 at 20:45 +0300, Robert Berger wrote:
> - mtdcri(SDR0, *sdr_addr, upper_32_bits(res.start)); /*HIGH addr */
> - mtdcri(SDR0, *sdr_addr + 1, lower_32_bits(res.start)); /* Low addr */
> + SDR0_WRITE(sdr_addr, (u64)res.start >> 32); /*HIGH addr */
> + SDR0_WRITE(sdr_addr + 1, res.start & 0xFFFFFFFF); /* Low addr */
> +
>
> msi->msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
> - if (!msi->msi_dev)
> + if (msi->msi_dev)
> return -ENODEV;
The above changes look bad. The first one is stupid, the second one is clearly broken.
The diff us from good to bad right ? Looks like somebody added a very busted patch.
If I look at the code in current upstream, I see:
mtdcri(SDR0, *sdr_addr, upper_32_bits(res.start)); /*HIGH addr */
mtdcri(SDR0, *sdr_addr + 1, lower_32_bits(res.start)); /* Low addr */
msi->msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
if (!msi->msi_dev)
return -ENODEV;
Which looks correct. So this might be something specific to ELDK ?
Cheers,
Ben.
next prev parent reply other threads:[~2012-10-18 19:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <507EF5AD.5070203__24977.4320669987$1350497770$gmane$org@gmail.com>
2012-10-18 16:27 ` ELDK 4.2/kilauea/3.5+ kernel broken Robert Berger
2012-10-18 16:33 ` Robert Berger
[not found] ` <50802F4C.3000309__36526.1883860969$1350578085$gmane$org@gmail.com>
2012-10-18 17:45 ` Robert Berger
2012-10-18 19:03 ` Benjamin Herrenschmidt [this message]
2012-10-18 20:05 ` Robert Berger
2012-10-19 3:16 ` Mai La
2012-10-19 6:35 ` Robert Berger
[not found] ` <1350587006.2476.12.camel__24873.815305955$1350587085$gmane$org@pasglop>
2012-10-21 15:35 ` Robert Berger
2012-10-21 20:01 ` Benjamin Herrenschmidt
[not found] ` <1350849666.2476.138.camel__11705.9888471433$1350849778$gmane$org@pasglop>
2012-10-24 5:45 ` Robert Berger
2013-01-04 4:08 ` Benjamin Herrenschmidt
2012-10-21 15:39 ` Robert Berger
2012-10-17 18:15 Robert Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350587006.2476.12.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mla@apm.com \
--cc=robert.karl.berger@gmail.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.