From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399 Date: Mon, 04 Dec 2017 15:22:07 +0200 Message-ID: <13507001.EQOuo8KY2k@avalon> References: <20171129184755.77187-1-briannorris@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171129184755.77187-1-briannorris@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Norris Cc: mark.rutland@arm.com, Doug Anderson , linux-rockchip@lists.infradead.org, David Airlie , zyw@rock-chips.com, hoegsberg@gmail.com, Philippe Cornu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yannick Fertre , Nickey Yang , mka@chromium.org, robh+dt@kernel.org, xbl@rock-chips.com, Vincent Abriou , hl@rock-chips.com List-Id: linux-rockchip.vger.kernel.org SGkgTmlja2V5LAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBXZWRuZXNkYXksIDI5IE5v dmVtYmVyIDIwMTcgMjA6NDc6NTUgRUVUIEJyaWFuIE5vcnJpcyB3cm90ZToKPiBGcm9tOiBOaWNr ZXkgWWFuZyA8bmlja2V5LnlhbmdAcm9jay1jaGlwcy5jb20+Cj4gCj4gV2UgbWlnaHQgaW5jbHVk ZSBhZGRpdGlvbmFsIHBvcnRzIGluIGRlcml2YXRpdmUgZGV2aWNlIHRyZWVzLCBzbyB0aGUKPiAn cG9ydCcgbm9kZSBzaG91bGQgaGF2ZSBhbiBhZGRyZXNzLCBhbmQgdGhlIHBhcmVudCAncG9ydHMn IG5vZGUgbmVlZHMKPiAvI3thZGRyZXMsc2l6ZX0tY2VsbHMuCj4gCj4gdjQ6Cj4gICoga2VlcCAj e2FkZHJlc3Msc2l6ZX0tY2VsbHMgaW4gYm90aCAncG9ydHMnIGFuZCAncG9ydEAwJyBub2Rlcwo+ ICAqIHNlcGFyYXRlIGZyb20gdGhlIHJlc3Qgb2YgdGhlIHNlcmllcywgc2luY2UgdGhpcyBpcyBt b3N0bHkKPiAgICBpbmRlcGVuZGVudCBvZiB0aGUgZHJpdmVyIHJlZmFjdG9yaW5nCj4gCj4gU2ln bmVkLW9mZi1ieTogTmlja2V5IFlhbmcgPG5pY2tleS55YW5nQHJvY2stY2hpcHMuY29tPgo+IFNp Z25lZC1vZmYtYnk6IEJyaWFuIE5vcnJpcyA8YnJpYW5ub3JyaXNAY2hyb21pdW0ub3JnPgoKUmV2 aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJk LmNvbT4KCj4gLS0tCj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LmR0c2kg fCA2ICsrKysrLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5 LmR0c2kKPiBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LmR0c2kgaW5kZXgg ZDM0MGI1OGFiMTg0Li5jNmRhZTI1YTNmMjMKPiAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jv b3QvZHRzL3JvY2tjaGlwL3JrMzM5OS5kdHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9y b2NrY2hpcC9yazMzOTkuZHRzaQo+IEBAIC0xNjUyLDcgKzE2NTIsMTEgQEAKPiAgCQlzdGF0dXMg PSAiZGlzYWJsZWQiOwo+IAo+ICAJCXBvcnRzIHsKPiAtCQkJbWlwaV9pbjogcG9ydCB7Cj4gKwkJ CSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ICsJCQkjc2l6ZS1jZWxscyA9IDwwPjsKPiArCj4gKwkJ CW1pcGlfaW46IHBvcnRAMCB7Cj4gKwkJCQlyZWcgPSA8MD47Cj4gIAkJCQkjYWRkcmVzcy1jZWxs cyA9IDwxPjsKPiAgCQkJCSNzaXplLWNlbGxzID0gPDA+OwoKCi0tIApSZWdhcmRzLAoKTGF1cmVu dCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753619AbdLDNV5 (ORCPT ); Mon, 4 Dec 2017 08:21:57 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:37800 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753157AbdLDNVy (ORCPT ); Mon, 4 Dec 2017 08:21:54 -0500 From: Laurent Pinchart To: Brian Norris Cc: heiko@sntech.de, Archit Taneja , Andrzej Hajda , David Airlie , Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Vincent Abriou , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sean Paul , Nickey Yang , hl@rock-chips.com, linux-rockchip@lists.infradead.org, mka@chromium.org, Doug Anderson , robh+dt@kernel.org, mark.rutland@arm.com, hoegsberg@gmail.com, zyw@rock-chips.com, xbl@rock-chips.com Subject: Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399 Date: Mon, 04 Dec 2017 15:22:07 +0200 Message-ID: <13507001.EQOuo8KY2k@avalon> Organization: Ideas on Board Oy In-Reply-To: <20171129184755.77187-1-briannorris@chromium.org> References: <20171129184755.77187-1-briannorris@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nickey, Thank you for the patch. On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote: > From: Nickey Yang > > We might include additional ports in derivative device trees, so the > 'port' node should have an address, and the parent 'ports' node needs > /#{addres,size}-cells. > > v4: > * keep #{address,size}-cells in both 'ports' and 'port@0' nodes > * separate from the rest of the series, since this is mostly > independent of the driver refactoring > > Signed-off-by: Nickey Yang > Signed-off-by: Brian Norris Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d340b58ab184..c6dae25a3f23 > 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1652,7 +1652,11 @@ > status = "disabled"; > > ports { > - mipi_in: port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mipi_in: port@0 { > + reg = <0>; > #address-cells = <1>; > #size-cells = <0>; -- Regards, Laurent Pinchart