From: Alexander Aring <alex.aring@googlemail.com>
To: barebox@lists.infradead.org
Subject: [PATCH 4/8] nandtest: change flash length variable type
Date: Mon, 22 Oct 2012 09:23:28 +0200 [thread overview]
Message-ID: <1350890612-10588-5-git-send-email-alex.aring@gmail.com> (raw)
In-Reply-To: <1350890612-10588-1-git-send-email-alex.aring@gmail.com>
Change flash 'length' variable type to off_t instead of int.
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
commands/nandtest.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/commands/nandtest.c b/commands/nandtest.c
index 656fb65..e25f062 100644
--- a/commands/nandtest.c
+++ b/commands/nandtest.c
@@ -195,9 +195,8 @@ static void print_stats(int nr_passes, int length)
/* Main program. */
static int do_nandtest(int argc, char *argv[])
{
- int opt, length = -1, do_nandtest_dev = -1;
- off_t flash_offset = 0;
- off_t test_ofs;
+ int opt, do_nandtest_dev = -1;
+ off_t flash_offset = 0, test_ofs, length = 0;
unsigned int nr_iterations = 1, iter;
int i;
int ret = -1;
@@ -272,7 +271,7 @@ static int do_nandtest(int argc, char *argv[])
goto err;
}
- if (length == -1) {
+ if (!length) {
length = meminfo.size;
length -= flash_offset;
}
@@ -292,13 +291,13 @@ static int do_nandtest(int argc, char *argv[])
}
if (length % meminfo.erasesize) {
printf("Length 0x%08x not multiple of erase size 0x%08x\n",
- length, meminfo.erasesize);
+ (unsigned)length, meminfo.erasesize);
goto err;
}
if (length + flash_offset > meminfo.size) {
printf("Length 0x%08x + offset 0x%08x exceeds "
- "device size 0x%08x\n",
- length, (unsigned)flash_offset, meminfo.size);
+ "device size 0x%08x\n", (unsigned)length,
+ (unsigned)flash_offset, meminfo.size);
goto err;
}
--
1.7.12.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-22 7:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 7:23 [PATCH 0/8] improve nandtest command Alexander Aring
2012-10-22 7:23 ` [PATCH 1/8] nandtest: stat ecc per page not per eraseblock Alexander Aring
2012-10-22 7:23 ` [PATCH 2/8] nandtest: add progressbar instead of offset print Alexander Aring
2012-10-22 7:23 ` [PATCH 3/8] nandtest: rename command argument p to i Alexander Aring
2012-10-22 7:23 ` Alexander Aring [this message]
2012-10-22 7:23 ` [PATCH 5/8] nandtest: use get_random_bytes instead of for loop Alexander Aring
2012-10-22 7:23 ` [PATCH 6/8] nandtest: clean up code Alexander Aring
2012-10-22 7:23 ` [PATCH 7/8] nandtest: use loff_t instead off_t Alexander Aring
2012-10-22 7:23 ` [PATCH 8/8] nandtest: add another constraints check Alexander Aring
2012-10-23 6:27 ` [PATCH 0/8] improve nandtest command Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350890612-10588-5-git-send-email-alex.aring@gmail.com \
--to=alex.aring@googlemail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.