From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] PACKAGES_DYNAMIC: use regexp not glob
Date: Mon, 22 Oct 2012 13:26:06 +0100 [thread overview]
Message-ID: <1350908766.2520.88.camel@ted> (raw)
In-Reply-To: <1350038799-22567-1-git-send-email-Martin.Jansa@gmail.com>
On Fri, 2012-10-12 at 12:46 +0200, Martin Jansa wrote:
> * bitbake uses PACKAGES_DYNAMIC as regexp
> ^ could make matching faster (and it will be more clear that we're expecting regexp not glob)
> * made all those last '-' optional, use .* (or nothing)
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> meta/classes/kernel.bbclass | 6 +++---
> meta/conf/bitbake.conf | 2 +-
> meta/recipes-connectivity/connman/connman.inc | 2 +-
> meta/recipes-core/eglibc/eglibc-locale.inc | 6 +++---
> meta/recipes-core/packagegroups/packagegroup-core-sdk.bb | 2 +-
> meta/recipes-devtools/perl/perl_5.14.2.bb | 4 ++--
> meta/recipes-extended/lighttpd/lighttpd_1.4.31.bb | 2 +-
> meta/recipes-extended/pam/libpam_1.1.6.bb | 2 +-
> meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb | 2 +-
> meta/recipes-gnome/gtk+/gtk+_2.24.8.bb | 2 +-
> meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb | 2 +-
> meta/recipes-graphics/directfb/directfb.inc | 2 +-
> meta/recipes-graphics/mesa/mesa-dri.inc | 2 +-
> meta/recipes-graphics/pango/pango.inc | 2 +-
> meta/recipes-kernel/linux/linux-dummy.bb | 4 ++--
> meta/recipes-multimedia/gstreamer/gst-plugins.inc | 2 +-
> meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 2 +-
> meta/recipes-qt/qt-apps/qmmp_0.6.1.bb | 2 +-
> meta/recipes-qt/qt4/qt4-embedded.inc | 2 +-
> meta/recipes-qt/qt4/qt4.inc | 2 +-
> 20 files changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 36bc3c7..b17b0f5 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -24,9 +24,9 @@ python __anonymous () {
>
> inherit kernel-arch deploy
>
> -PACKAGES_DYNAMIC += "kernel-module-*"
> -PACKAGES_DYNAMIC += "kernel-image-*"
> -PACKAGES_DYNAMIC += "kernel-firmware-*"
> +PACKAGES_DYNAMIC += "^kernel-module-.*"
> +PACKAGES_DYNAMIC += "^kernel-image-.*"
> +PACKAGES_DYNAMIC += "^kernel-firmware-.*"
FWIW, these changes broke multilib. I've proposed a patch which at least
makes the mulitlib builds work again.
Cheers,
Richard
prev parent reply other threads:[~2012-10-22 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 10:46 [PATCH 1/2] PACKAGES_DYNAMIC: use regexp not glob Martin Jansa
2012-10-12 10:46 ` [PATCH 2/2] PACKAGES_DYNAMIC: use += instead of = in most cases Martin Jansa
2012-10-12 17:40 ` [PATCH 1/2] PACKAGES_DYNAMIC: use regexp not glob Saul Wold
2012-10-12 17:56 ` Martin Jansa
2012-10-16 19:39 ` Saul Wold
2012-10-16 22:32 ` Martin Jansa
2012-10-16 22:34 ` [PATCH] kernel.bbclass: add kernel-modules to PACKAGES Martin Jansa
2012-10-19 21:05 ` [PATCH 1/2] PACKAGES_DYNAMIC: use regexp not glob Saul Wold
2012-10-22 12:26 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350908766.2520.88.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.