Re: [PATCH 5 of 6] xen: sched_sedf: beautify statisics in SEDF

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 3422 bytes --]

On Tue, 2012-10-23 at 17:26 +0100, George Dunlap wrote:
> On 22/10/12 15:40, Dario Faggioli wrote:
> > By gathering all the related fields in a struct (as it is being done
> > in credit) and using the macros we now have available. No functional
> > changes involved.
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> 
> I'm OK with this as it is, but...
> 
Ok.

> >   #ifdef SEDF_STATS
> > -    if ( EDOM_INFO(d)->block_time_tot != 0 )
> > -        printk(" pen=%"PRIu64"%%", (EDOM_INFO(d)->penalty_time_tot * 100) /
> > -               EDOM_INFO(d)->block_time_tot);
> > -    if ( EDOM_INFO(d)->block_tot != 0 )
> > +    if ( EDOM_INFO(d)->stats.block_time_tot != 0 )
> > +        printk(" pen=%"PRIu64"%%", (EDOM_INFO(d)->stats.penalty_time_tot * 100) /
> > +               EDOM_INFO(d)->stats.block_time_tot);
> > +    if ( EDOM_INFO(d)->stats.block_tot != 0 )
> >           printk("\n   blks=%u sh=%u (%u%%) (shc=%u (%u%%) shex=%i "\
> >                  "shexsl=%i) l=%u (%u%%) avg: b=%"PRIu64" p=%"PRIu64"",
> > -               EDOM_INFO(d)->block_tot, EDOM_INFO(d)->short_block_tot,
> > -               (EDOM_INFO(d)->short_block_tot * 100)
> > -               / EDOM_INFO(d)->block_tot, EDOM_INFO(d)->short_cont,
> > -               (EDOM_INFO(d)->short_cont * 100) / EDOM_INFO(d)->block_tot,
> > -               EDOM_INFO(d)->pen_extra_blocks,
> > -               EDOM_INFO(d)->pen_extra_slices,
> > -               EDOM_INFO(d)->long_block_tot,
> > -               (EDOM_INFO(d)->long_block_tot * 100) / EDOM_INFO(d)->block_tot,
> > -               (EDOM_INFO(d)->block_time_tot) / EDOM_INFO(d)->block_tot,
> > -               (EDOM_INFO(d)->penalty_time_tot) / EDOM_INFO(d)->block_tot);
> > +               EDOM_INFO(d)->stats.block_tot, EDOM_INFO(d)->stats.short_block_tot,
> > +               (EDOM_INFO(d)->stats.short_block_tot * 100)
> > +               / EDOM_INFO(d)->stats.block_tot, EDOM_INFO(d)->stats.short_cont,
> > +               (EDOM_INFO(d)->stats.short_cont * 100) / EDOM_INFO(d)->stats.block_tot,
> > +               EDOM_INFO(d)->stats.pen_extra_blocks,
> > +               EDOM_INFO(d)->stats.pen_extra_slices,
> > +               EDOM_INFO(d)->stats.long_block_tot,
> > +               (EDOM_INFO(d)->stats.long_block_tot * 100) / EDOM_INFO(d)->stats.block_tot,
> > +               (EDOM_INFO(d)->stats.block_time_tot) / EDOM_INFO(d)->stats.block_tot,
> > +               (EDOM_INFO(d)->stats.penalty_time_tot) / EDOM_INFO(d)->stats.block_tot);
> 
> ...wouldn't it be even more beautiful to have a macro for reading stats 
> as well?
> 
> Like I said, it's fine as it is, but since you're looking for beauty, I 
> figured I'd point it out. :-)
> 
I see what you mean. Again, as you wish.

This code will need some (and quite a bit actually) of attention as soon
as I or someone else get the time to work on it. If you're fine about
taking this as is, I'll make a note to self about the macro (as I agree
it would be nice).

OTOH, if you prefer me to repost the patch, I think I can find 5 mins to
hack it up...

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel