From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Maslenkin <mihailm@parallels.com>
Subject: Re: [PATCH 2/2] Improve container_notify_cb() to support container
 hot-remove.
Date: Wed, 24 Oct 2012 01:54:21 +0400
Message-ID: <1351029261.16186.3.camel@QWERTY1.site>
References: <1350997839-13260-1-git-send-email-tangchen@cn.fujitsu.com>
	 <1350997839-13260-3-git-send-email-tangchen@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from relay.swsoft.eu ([109.70.220.8]:42474 "EHLO relay.swsoft.eu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932796Ab2JWWGV (ORCPT <rfc822;linux-acpi@vger.kernel.org>);
	Tue, 23 Oct 2012 18:06:21 -0400
In-Reply-To: <1350997839-13260-3-git-send-email-tangchen@cn.fujitsu.com>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: linux-acpi@vger.kernel.org

On Tue, 2012-10-23 at 21:10 +0800, Tang Chen wrote:
> +static int container_device_remove(struct acpi_device *device)
> +{
> +	int ret;
> +	struct acpi_eject_event *ej_event;
> +
> +	ej_event = kmalloc(sizeof(*ej_event), GFP_KERNEL);
> +	if (!ej_event)
> +		return -ENOMEM;
> +
> +	ej_event->device = device;
> +	ej_event->event = ACPI_NOTIFY_EJECT_REQUEST;
> +
> +	/* stop container device at first */
> +	ret = acpi_bus_trim(device, 0);
> +	printk(KERN_WARNING "acpi_bus_trim stop return %x\n", ret);
> +	if (ret)
> +		return ret;
> +
Looks like kfree() is missed here. Would it be better to stop container
before event allocation?


Mike.