From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@adurom.com>
Cc: Bing Zhao <bzhao@marvell.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Sam Leffler <sleffler@chromium.org>,
Amitkumar Karwar <akarwar@marvell.com>
Subject: Re: [PATCH v6 4/6] wireless: use OR operation to set wiphy features
Date: Wed, 24 Oct 2012 11:01:28 +0200 [thread overview]
Message-ID: <1351069288.10709.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <87d308z1no.fsf@purkki.adurom.net>
On Wed, 2012-10-24 at 11:59 +0300, Kalle Valo wrote:
> Is there a way to check that drivers don't accidentally clear the flags
> (ie. use '=' instead '|=')? For example by adding a dummy flag and
> checking afterwards that it's not cleared?
>
> I'm just worried that this detail might be too easy to miss, for example
> somehow I had missed this patch and noticed only when rebasing ath6kl
> patches.
Yes, that should be possible, set some dummy flag in wiphy_new() and
test & clear it in wiphy_register()?
johannes
next prev parent reply other threads:[~2012-10-24 9:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 6:34 [PATCH v6 0/6] add scan flags support Bing Zhao
2012-10-18 6:34 ` [PATCH v6 1/6] {nl,cfg}80211: add a flags word to scan requests Bing Zhao
2012-10-18 6:34 ` [PATCH v6 2/6] cfg80211: code rearrangement to avoid forward declarations Bing Zhao
2012-10-18 6:34 ` [PATCH v6 3/6] cfg80211: add scan flag to indicate its priority Bing Zhao
2012-10-18 7:26 ` Arend van Spriel
2012-10-18 18:44 ` Bing Zhao
2012-10-19 8:00 ` Arend van Spriel
2012-10-18 6:34 ` [PATCH v6 4/6] wireless: use OR operation to set wiphy features Bing Zhao
2012-10-24 8:59 ` Kalle Valo
2012-10-24 9:01 ` Johannes Berg [this message]
2012-10-24 9:03 ` Kalle Valo
2012-10-24 9:10 ` Johannes Berg
2012-10-18 6:34 ` [PATCH v6 5/6] cfg80211: add support for flushing old scan results Bing Zhao
2012-10-18 6:34 ` [PATCH v6 6/6] mac80211: add support for tx to abort low priority scan requests Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351069288.10709.2.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sleffler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.