All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>, Jiri Olsa <jolsa@redhat.com>,
	Borislav Petkov <bp@amd64.org>
Subject: [PATCH 5/5] perf tools: Fix LIBELF_MMAP checking
Date: Fri, 26 Oct 2012 17:55:52 +0900	[thread overview]
Message-ID: <1351241752-2919-5-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1351241752-2919-1-git-send-email-namhyung@kernel.org>

From: Namhyung Kim <namhyung.kim@lge.com>

Currently checking mmap support in libelf failed due to wrong flags.

    CHK libelf
    CHK libdw
    CHK libunwind
    CHK -DLIBELF_MMAP
/tmp/ccYJwdR0.o: In function `main':
:(.text+0x18): undefined reference to `elf_begin'
collect2: error: ld returned 1 exit status

This cannot happen since we checked the elf_begin() when checking
libelf and it succeeded.

Fix it by using a same flag with libelf checking.

Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Borislav Petkov <bp@amd64.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 2d0c09ab58b8..629fc6a4b0df 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -541,7 +541,8 @@ LIB_OBJS += $(OUTPUT)util/symbol-minimal.o
 else # NO_LIBELF
 BASIC_CFLAGS += -DLIBELF_SUPPORT
 
-ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_COMMON),-DLIBELF_MMAP),y)
+FLAGS_LIBELF=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS)
+ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DLIBELF_MMAP),y)
 	BASIC_CFLAGS += -DLIBELF_MMAP
 endif
 
-- 
1.7.11.7


  parent reply	other threads:[~2012-10-26  8:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26  8:55 [PATCH RESEND 1/5] tools lib traceevent: Do not generate dependency for system header files Namhyung Kim
2012-10-26  8:55 ` [PATCH 2/5] perf tools: Cleanup doc related targets Namhyung Kim
2012-10-26 15:05   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-10-26  8:55 ` [PATCH 3/5] perf tools: Convert invocation of MAKE into SUBDIR Namhyung Kim
2012-10-26 15:06   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-10-26  8:55 ` [PATCH 4/5] perf tools: Always show CHK message when doing try-cc Namhyung Kim
2012-10-26 12:48   ` Arnaldo Carvalho de Melo
2012-10-26 13:00   ` Jiri Olsa
2012-10-26 15:07   ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-10-26  8:55 ` Namhyung Kim [this message]
2012-10-26 15:08   ` [tip:perf/core] perf tools: Fix LIBELF_MMAP checking tip-bot for Namhyung Kim
2012-10-26 15:04 ` [tip:perf/core] tools lib traceevent: Do not generate dependency for system header files tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351241752-2919-5-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=bp@amd64.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.