All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] sstate.bbclass: preserve time when unstaging files
Date: Mon, 29 Oct 2012 16:11:42 +0000	[thread overview]
Message-ID: <1351527102.2828.19.camel@ted> (raw)
In-Reply-To: <1351523465-26489-1-git-send-email-enrico.scholz@sigma-chemnitz.de>

On Mon, 2012-10-29 at 16:11 +0100, Enrico Scholz wrote:
> When packages are recreated after a 'bitbake -c clean', files will get
> wrong date because tar has been invoked with the '-m' option.
> 
> Correct timestamps are useful for bug hunting and there are better
> ways (e.g. using of ntp) than using '-m'.
> 
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> ---
>  meta/classes/sstate.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> index cbb14e1..d7c4e11 100644
> --- a/meta/classes/sstate.bbclass
> +++ b/meta/classes/sstate.bbclass
> @@ -551,7 +551,7 @@ sstate_create_package () {
>  sstate_unpack_package () {
>  	mkdir -p ${SSTATE_INSTDIR}
>  	cd ${SSTATE_INSTDIR}
> -	tar -xmvzf ${SSTATE_PKG}
> +	tar -xvzf ${SSTATE_PKG}
>  }
>  
>  # Need to inject information about classes not in the global configuration scope

This is a revert of:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=2d89cff42af2bb0049224bfaaebaa2b21966169f

where the option was added deliberately to deal with time mismatch
between autobuilders which was causing real world bugs.

Cheers,

Richard




  reply	other threads:[~2012-10-29 16:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-29 15:11 [PATCH] sstate.bbclass: preserve time when unstaging files Enrico Scholz
2012-10-29 16:11 ` Richard Purdie [this message]
2012-10-29 16:24   ` Enrico Scholz
2012-10-29 17:22     ` Richard Purdie
2012-10-29 17:59       ` Enrico Scholz
2012-10-29 18:19         ` Richard Purdie
2012-10-29 19:00           ` Enrico Scholz
2012-10-29 21:20             ` Richard Purdie
2012-10-29 21:41               ` Enrico Scholz
2012-10-29 21:55                 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351527102.2828.19.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=enrico.scholz@sigma-chemnitz.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.