All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Brulebois <kibi@debian.org>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: romieu@fr.zoreil.com, nic_swsd@realtek.com,
	linux-kernel@vger.kernel.org, florent.fourcot@enst-bretagne.fr,
	Cyril Brulebois <kibi@debian.org>
Subject: [PATCH v2] r8169: Fix WoL on RTL8168d/8111d.
Date: Thu,  1 Nov 2012 01:00:46 +0100	[thread overview]
Message-ID: <1351728046-32105-1-git-send-email-kibi@debian.org> (raw)
In-Reply-To: <20121028230523.GA26778@electric-eye.fr.zoreil.com>

This regression was spotted between Debian squeeze and Debian wheezy
kernels (respectively based on 2.6.32 and 3.2). More info about
Wake-on-LAN issues with Realtek's 816x chipsets can be found in the
following thread: http://marc.info/?t=132079219400004

Probable regression from d4ed95d796e5126bba51466dc07e287cebc8bd19;
more chipsets are likely affected.

Tested on top of a 3.2.23 kernel.

Reported-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
Tested-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr>
Hinted-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Cyril Brulebois <kibi@debian.org>
---
 drivers/net/ethernet/realtek/r8169.c |    2 ++
 1 file changed, 2 insertions(+)

v2: Update link in commit message, and re-send to netdev/Dave according
    to Francois Romieu's comment, thanks.

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index e7ff886..eb6a5e4 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -3827,6 +3827,8 @@ static void rtl_wol_suspend_quirk(struct rtl8169_private *tp)
 	void __iomem *ioaddr = tp->mmio_addr;
 
 	switch (tp->mac_version) {
+	case RTL_GIGA_MAC_VER_25:
+	case RTL_GIGA_MAC_VER_26:
 	case RTL_GIGA_MAC_VER_29:
 	case RTL_GIGA_MAC_VER_30:
 	case RTL_GIGA_MAC_VER_32:
-- 
1.7.10.4


  parent reply	other threads:[~2012-11-01  0:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-28  2:46 [PATCH] r8169: Fix WoL on RTL8168d/8111d Cyril Brulebois
2012-10-28 23:05 ` Francois Romieu
2012-10-29  0:21   ` Cyril Brulebois
2012-10-29 23:01     ` Francois Romieu
2012-11-01  0:00   ` Cyril Brulebois [this message]
2012-11-01 22:21     ` [PATCH v2] " Francois Romieu
2012-11-03 19:16       ` David Miller
2012-11-12 16:38       ` [3.0.y, 3.2.y, 3.4.y] " Jonathan Nieder
2012-11-12 23:03         ` Francois Romieu
2012-11-12 23:27           ` David Miller
2012-11-13 20:24             ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351728046-32105-1-git-send-email-kibi@debian.org \
    --to=kibi@debian.org \
    --cc=davem@davemloft.net \
    --cc=florent.fourcot@enst-bretagne.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.