All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 4/6] xfs: don't vmap inode cluster buffers during free
Date: Fri,  2 Nov 2012 11:38:42 +1100	[thread overview]
Message-ID: <1351816724-3000-5-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1351816724-3000-1-git-send-email-david@fromorbit.com>

From: Dave Chinner <dchinner@redhat.com>

Inode buffers do not need to be mapped as inodes are read or written
directly from/to the pages underlying the buffer. This fixes a
regression introduced by commit 611c994 ("xfs: make XBF_MAPPED the
default behaviour").

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 fs/xfs/xfs_inode.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index bba8f37..6a0a710 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1760,7 +1760,8 @@ xfs_ifree_cluster(
 		 * to mark all the active inodes on the buffer stale.
 		 */
 		bp = xfs_trans_get_buf(tp, mp->m_ddev_targp, blkno,
-					mp->m_bsize * blks_per_cluster, 0);
+					mp->m_bsize * blks_per_cluster,
+					XBF_UNMAPPED);
 
 		if (!bp)
 			return ENOMEM;
-- 
1.7.10

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2012-11-02  0:37 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  0:38 [PATCH 0/6] xfs: fixes for 3.7-rc3 Dave Chinner
2012-11-02  0:38 ` [PATCH 1/6] xfs: silence uninitialised f.file warning Dave Chinner
2012-11-02 13:04   ` Christoph Hellwig
2012-11-02 21:23   ` Mark Tinguely
2012-11-02  0:38 ` [PATCH 2/6] xfs: growfs: don't read garbage for new secondary superblocks Dave Chinner
2012-11-02  0:38 ` [PATCH 3/6] xfs: invalidate allocbt blocks moved to the free list Dave Chinner
2012-10-09 19:11   ` [PATCH] xfs: report projid32bit feature in geometry call Eric Sandeen
2012-10-09 19:28     ` Carlos Maiolino
2012-10-09 19:45     ` Dave Chinner
2012-10-11  0:02     ` Eric Sandeen
2012-10-30 19:43       ` Ben Myers
2012-10-30 19:44         ` Eric Sandeen
2012-11-08 16:12     ` Ben Myers
2012-11-02 21:23   ` [PATCH 3/6] xfs: invalidate allocbt blocks moved to the free list Mark Tinguely
2012-11-02  0:38 ` Dave Chinner [this message]
2012-11-02 13:05   ` [PATCH 4/6] xfs: don't vmap inode cluster buffers during free Christoph Hellwig
2012-11-02 21:24   ` Mark Tinguely
2012-11-02  0:38 ` [PATCH 5/6] xfs: fix buffer shudown reference count mismatch Dave Chinner
2012-11-02  2:43   ` Dave Chinner
2012-11-02  3:23     ` [PATCH 5/6 V2] " Dave Chinner
2012-11-02 13:17       ` Mark Tinguely
2012-11-02 13:13     ` [PATCH 5/6] " Christoph Hellwig
2012-11-02 17:10       ` Mark Tinguely
2012-11-02 23:47       ` Dave Chinner
2012-11-06 12:59         ` Christoph Hellwig
2012-11-06 19:59           ` Dave Chinner
2012-11-02  0:38 ` [PATCH 6/6] xfs: fix reading of wrapped log data Dave Chinner
2012-11-02 13:07   ` Christoph Hellwig
2012-11-02 23:51     ` Dave Chinner
2012-11-02 21:24   ` Mark Tinguely
2012-11-07 20:56 ` [PATCH 0/6] xfs: fixes for 3.7-rc3 Dave Chinner
2012-11-08 16:34   ` Ben Myers
2012-11-08 16:15 ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351816724-3000-5-git-send-email-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.