From: Tommi Rantala <tt.rantala@gmail.com>
To: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: [PATCH 5/6] drm/radeon: check alloc_apertures() success in radeon_kick_out_firmware_fb()
Date: Fri, 9 Nov 2012 11:19:39 +0200 [thread overview]
Message-ID: <1352452780-2029-6-git-send-email-tt.rantala@gmail.com> (raw)
In-Reply-To: <1352452780-2029-1-git-send-email-tt.rantala@gmail.com>
Check for alloc_apertures() memory allocation failure, and propagate an
error code in case the allocation failed.
Signed-off-by: Tommi Rantala <tt.rantala@gmail.com>
---
drivers/gpu/drm/radeon/radeon_drv.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 07eb84e..8c1a83c 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -281,12 +281,15 @@ static struct drm_driver driver_old = {
static struct drm_driver kms_driver;
-static void radeon_kick_out_firmware_fb(struct pci_dev *pdev)
+static int radeon_kick_out_firmware_fb(struct pci_dev *pdev)
{
struct apertures_struct *ap;
bool primary = false;
ap = alloc_apertures(1);
+ if (!ap)
+ return -ENOMEM;
+
ap->ranges[0].base = pci_resource_start(pdev, 0);
ap->ranges[0].size = pci_resource_len(pdev, 0);
@@ -295,13 +298,19 @@ static void radeon_kick_out_firmware_fb(struct pci_dev *pdev)
#endif
remove_conflicting_framebuffers(ap, "radeondrmfb", primary);
kfree(ap);
+
+ return 0;
}
static int __devinit
radeon_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
{
+ int ret;
+
/* Get rid of things like offb */
- radeon_kick_out_firmware_fb(pdev);
+ ret = radeon_kick_out_firmware_fb(pdev);
+ if (ret)
+ return ret;
return drm_get_pci_dev(pdev, ent, &kms_driver);
}
--
1.7.9.5
next prev parent reply other threads:[~2012-11-09 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 9:19 [PATCH 0/6] alloc_apertures() handling fixes Tommi Rantala
2012-11-09 9:19 ` [PATCH 1/6] drm/cirrus: check alloc_apertures() success in cirrus_kick_out_firmware_fb() Tommi Rantala
2012-11-09 9:19 ` [PATCH 2/6] drm/mgag200: check alloc_apertures() success in mga_vram_init() Tommi Rantala
2012-11-09 9:19 ` [PATCH 3/6] drm/mgag200: free memory allocated with alloc_apertures() Tommi Rantala
2012-11-09 9:19 ` [PATCH 4/6] drm/mgag200: remove unneeded aper->count assignment after alloc_apertures() Tommi Rantala
2012-11-09 9:19 ` Tommi Rantala [this message]
2012-11-09 9:19 ` [PATCH 6/6] drm/nouveau: free memory allocated with alloc_apertures() Tommi Rantala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352452780-2029-6-git-send-email-tt.rantala@gmail.com \
--to=tt.rantala@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.