All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomas Hozza <thozza@redhat.com>
To: olaf@aepfle.de, kys@microsoft.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	apw@canonical.com, jasowang@redhat.com, ben@decadent.org.uk
Cc: Tomas Hozza <thozza@redhat.com>
Subject: [PATCH 2/3] tools/hv: Fix string types
Date: Fri,  9 Nov 2012 15:01:20 +0100	[thread overview]
Message-ID: <1352469681-4432-2-git-send-email-thozza@redhat.com> (raw)
In-Reply-To: <1352469681-4432-1-git-send-email-thozza@redhat.com>

Initial patch by Ben Hutchings <ben@decadent.org.uk>

Standard C strings are arrays of char, not __u8 (unsigned char).
Declare variables and parameters accordingly, and add the necessary
casts.

Signed-off-by: Tomas Hozza <thozza@redhat.com>
---
 tools/hv/hv_kvp_daemon.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index d9b3a74..573b9aa 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -300,7 +300,7 @@ static int kvp_file_init(void)
 	return 0;
 }
 
-static int kvp_key_delete(int pool, __u8 *key, int key_size)
+static int kvp_key_delete(int pool, const char *key, int key_size)
 {
 	int i;
 	int j, k;
@@ -343,7 +343,7 @@ static int kvp_key_delete(int pool, __u8 *key, int key_size)
 	return 1;
 }
 
-static int kvp_key_add_or_modify(int pool, __u8 *key, int key_size, __u8 *value,
+static int kvp_key_add_or_modify(int pool, const char *key, int key_size, const char *value,
 			int value_size)
 {
 	int i;
@@ -397,7 +397,7 @@ static int kvp_key_add_or_modify(int pool, __u8 *key, int key_size, __u8 *value,
 	return 0;
 }
 
-static int kvp_get_value(int pool, __u8 *key, int key_size, __u8 *value,
+static int kvp_get_value(int pool, const char *key, int key_size, char *value,
 			int value_size)
 {
 	int i;
@@ -429,8 +429,8 @@ static int kvp_get_value(int pool, __u8 *key, int key_size, __u8 *value,
 	return 1;
 }
 
-static int kvp_pool_enumerate(int pool, int index, __u8 *key, int key_size,
-				__u8 *value, int value_size)
+static int kvp_pool_enumerate(int pool, int index, char *key, int key_size,
+				char *value, int value_size)
 {
 	struct kvp_record *record;
 
-- 
1.7.11.7


  reply	other threads:[~2012-11-09 14:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 14:01 [PATCH 1/3] tools/hv: Fix /var subdirectory Tomas Hozza
2012-11-09 14:01 ` Tomas Hozza [this message]
2012-11-09 15:56   ` [PATCH 2/3] tools/hv: Fix string types KY Srinivasan
2012-11-09 14:01 ` [PATCH 3/3] tools/hv: Fix permissions of created directory and files Tomas Hozza
2012-11-09 15:52   ` KY Srinivasan
2012-11-09 15:57   ` KY Srinivasan
2012-11-09 15:56 ` [PATCH 1/3] tools/hv: Fix /var subdirectory KY Srinivasan
2012-11-12  8:55   ` Tomas Hozza
2012-11-12  8:55     ` [PATCH 3/3] tools/hv: Fix permissions of created directory and files Tomas Hozza
2012-11-26 20:40       ` KY Srinivasan
2012-11-26 20:42     ` [PATCH 1/3] tools/hv: Fix /var subdirectory KY Srinivasan
2012-11-26 21:12       ` gregkh
2012-11-26 21:15         ` KY Srinivasan
2012-11-27  7:56           ` [PATCH 1/3] tools/hv: Fix for long file names from readdir Tomas Hozza
2012-11-27  7:56             ` [PATCH 2/3] tools/hv: Fix /var subdirectory Tomas Hozza
2012-11-27 13:59               ` KY Srinivasan
2012-11-27  7:56             ` [PATCH 3/3] tools/hv: Fix permissions of created directory and files Tomas Hozza
2012-11-27 13:59               ` KY Srinivasan
2012-11-27 13:58             ` [PATCH 1/3] tools/hv: Fix for long file names from readdir KY Srinivasan
2012-11-27 14:50             ` Ben Hutchings
2012-11-27 20:28               ` Tomas Hozza
2012-11-27 20:41                 ` Ben Hutchings
2012-12-18  8:06                   ` Tomas Hozza
2012-12-18 12:38                     ` Ben Hutchings
2013-01-17 18:41                       ` Greg KH
2012-11-15 23:38   ` [PATCH 1/3] tools/hv: Fix /var subdirectory gregkh
2012-11-15 23:52     ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352469681-4432-2-git-send-email-thozza@redhat.com \
    --to=thozza@redhat.com \
    --cc=apw@canonical.com \
    --cc=ben@decadent.org.uk \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.