From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 1/2] pty04: Use guarded buffers for transmission
Date: Wed, 6 May 2020 07:14:07 -0400 (EDT) [thread overview]
Message-ID: <1352538726.11479675.1588763647954.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAEemH2coDuWHPt8SMosAtpjNd4VxmkGw3FWWajUOYXaNN7o0og@mail.gmail.com>
----- Original Message -----
> > > Probably the best thing todo for now is to remove the test before the
> > > release as this requires some more investigation.
> >
> > We can keep it in tree, I'd just disable it in runtest file(s), so it's not
> > run by default.
> >
>
> But we still facing the compiled errors in the old kernels, that will break
> the LTP build in the compiling phase.
I see, that will fail on anything older than 4.10. I don't have strong
preference how to deal with that, just want to avoid running pty04 for now.
diff --git a/testcases/kernel/pty/pty04.c b/testcases/kernel/pty/pty04.c
index eaf172504a64..55923a0af006 100644
--- a/testcases/kernel/pty/pty04.c
+++ b/testcases/kernel/pty/pty04.c
@@ -38,7 +38,10 @@
#include "tst_buffers.h"
#include "config.h"
-#if defined(HAVE_LINUX_IF_PACKET_H) && defined(HAVE_LINUX_IF_ETHER_H)
+#include <linux/version.h>
+
+#if defined(HAVE_LINUX_IF_PACKET_H) && defined(HAVE_LINUX_IF_ETHER_H) \
+ && LINUX_VERSION_CODE >= KERNEL_VERSION(4, 10, 0)
#include <linux/if_packet.h>
#include <linux/if_ether.h>
@@ -373,6 +376,6 @@ static struct tst_test test = {
#else
-TST_TEST_TCONF("Need <linux/if_packet.h> and <linux/if_ether.h>");
+TST_TEST_TCONF("Need <linux/if_packet.h> and <linux/if_ether.h> and 4.10+");
next prev parent reply other threads:[~2020-05-06 11:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 10:16 [LTP] [PATCH v4 1/2] pty04: Use guarded buffers for transmission Richard Palethorpe
2020-05-05 10:16 ` [LTP] [PATCH v4 2/2] pty04: Add SLCAN ldisc and check for CVE-2020-11494 Richard Palethorpe
2020-05-05 13:35 ` Cyril Hrubis
2020-05-05 13:55 ` Petr Vorel
2020-05-05 15:18 ` Richard Palethorpe
2020-05-05 15:27 ` Petr Vorel
2020-05-05 13:37 ` [LTP] [PATCH v4 1/2] pty04: Use guarded buffers for transmission Petr Vorel
2020-05-05 14:47 ` Richard Palethorpe
2020-05-05 15:01 ` Petr Vorel
2020-05-05 15:11 ` Petr Vorel
2020-05-06 8:47 ` Richard Palethorpe
2020-05-06 10:49 ` Jan Stancek
2020-05-06 10:56 ` Li Wang
2020-05-06 11:14 ` Jan Stancek [this message]
2020-05-06 11:38 ` Petr Vorel
2020-05-06 12:06 ` Jan Stancek
2020-05-06 12:17 ` Petr Vorel
2020-05-06 12:20 ` Jan Stancek
2020-05-06 12:49 ` Cyril Hrubis
2020-05-06 13:49 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352538726.11479675.1588763647954.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.