From: Johannes Berg <johannes@sipsolutions.net>
To: MARK PHILLIPS <mark.phillips@virgin.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [BUG]: 3.7.0.rc2 iwlwifi: Mn=onitor mode for Intel 6235 includes FCS in frames
Date: Tue, 13 Nov 2012 21:28:33 +0100 [thread overview]
Message-ID: <1352838513.9466.31.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAAPJqkbqZhRm08N0mTfKcW1PKc=XdhqiC8-668s_ydwRAZ9M2Q@mail.gmail.com> (sfid-20121029_125608_365462_578D7DBB)
Hi Mark, sorry for the delay,
On Mon, 2012-10-29 at 11:56 +0000, MARK PHILLIPS wrote:
> I have found bug which breaks monitor mode for the Intel Centrino
> Advanced-N 6235. When in monitor mode the FCS is returned appended to
> the frames which confuses wireshark.
>
> The fix appears to be trivial, just add IEEE80211_HW_RX_INCLUDES_FCS
> to the hw->flags when in monitor mode via a change to
> drivers/net/wireless/iwlwifi/dvm/mac80211.c
Yes, this seems to be a reasonable change, unfortunately mac80211
doesn't provide a per packet flag whether the FCS is present or not.
I think I prefer doing the modification in iwlagn_mac_add_interface(),
and will also add a comment.
FWIW, this appears to be a regression introduced in
578977264199de9815ace51ade87cec4894cf010, which went into 3.5. I'm a bit
confused why this didn't appear in my tests though, so I'm trying to see
if different firmware versions behave differently.
johannes
next parent reply other threads:[~2012-11-13 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAPJqkbqZhRm08N0mTfKcW1PKc=XdhqiC8-668s_ydwRAZ9M2Q@mail.gmail.com>
2012-11-13 20:28 ` Johannes Berg [this message]
2012-11-22 1:03 ` [BUG]: 3.7.0.rc2 iwlwifi: Mn=onitor mode for Intel 6235 includes FCS in frames Mark Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352838513.9466.31.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.phillips@virgin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.