From: Heiko Stuebner <heiko@sntech.de>
To: sjg@chromium.org, philipp.tomsich@vrull.eu,
kever.yang@rock-chips.com,
Quentin Schulz <quentin.schulz@cherry.de>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] clk: rockchip: rk3588: fix mask define for aclk_vop_root
Date: Wed, 20 Nov 2024 12:26:45 +0100 [thread overview]
Message-ID: <13528783.O9o76ZdvQC@phil> (raw)
In-Reply-To: <4527740e-34c5-4669-b3ae-86792160b59d@cherry.de>
Am Mittwoch, 20. November 2024, 12:13:32 CET schrieb Quentin Schulz:
> On 11/20/24 11:19 AM, Heiko Stuebner wrote:
> > The mask for aclk_vop_root is 3-bit wide, not 2-bit wide according
> > to the TRM, so set the mask accordingly.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> Was this a drive-by bug fix or did you actually experience some bug?
> Basically trying to figure out if we should push for this being merged
> for 2025.01 or if it's fine if it misses it?
on my side, it was a "drive-by" thing and I actually don't remember
anymore, what made me look at that. So I don't experience any
bug on my side.
Heiko
next prev parent reply other threads:[~2024-11-20 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 10:19 [PATCH] clk: rockchip: rk3588: fix mask define for aclk_vop_root Heiko Stuebner
2024-11-20 11:13 ` Quentin Schulz
2024-11-20 11:26 ` Heiko Stuebner [this message]
2024-11-21 2:04 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13528783.O9o76ZdvQC@phil \
--to=heiko@sntech.de \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.