All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sharp <dhsharp@google.com>
To: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Cc: David Sharp <dhsharp@google.com>
Subject: [PATCH 4/4] kernelshark: Full-height cursor and mark lines
Date: Wed, 14 Nov 2012 17:51:14 -0800	[thread overview]
Message-ID: <1352944274-21699-4-git-send-email-dhsharp@google.com> (raw)
In-Reply-To: <1352944274-21699-1-git-send-email-dhsharp@google.com>

"width" and "height" were swapped, causing the vertical marker and cursor lines
to be drawn with the wrong height.

Signed-off-by: David Sharp <dhsharp@google.com>
---
 trace-graph.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/trace-graph.c b/trace-graph.c
index 6f72350..60e5241 100644
--- a/trace-graph.c
+++ b/trace-graph.c
@@ -380,7 +380,7 @@ static void draw_cursor(struct graph_info *ginfo)
 	x = convert_time_to_x(ginfo, ginfo->cursor);
 
 	gdk_draw_line(ginfo->draw->window, ginfo->draw->style->mid_gc[3],
-		      x, 0, x, ginfo->draw->allocation.width);
+		      x, 0, x, ginfo->draw->allocation.height);
 }
 
 static void draw_marka(struct graph_info *ginfo)
@@ -392,7 +392,7 @@ static void draw_marka(struct graph_info *ginfo)
 
 	x = convert_time_to_x(ginfo, ginfo->marka_time);
 	gdk_draw_line(ginfo->draw->window, green,
-		      x, 0, x, ginfo->draw->allocation.width);
+		      x, 0, x, ginfo->draw->allocation.height);
 }
 
 static void draw_markb(struct graph_info *ginfo)
@@ -404,7 +404,7 @@ static void draw_markb(struct graph_info *ginfo)
 
 	x = convert_time_to_x(ginfo, ginfo->markb_time);
 	gdk_draw_line(ginfo->draw->window, red,
-		      x, 0, x, ginfo->draw->allocation.width);
+		      x, 0, x, ginfo->draw->allocation.height);
 }
 
 static void update_with_backend(struct graph_info *ginfo,
@@ -434,7 +434,7 @@ static void
 draw_line(GtkWidget *widget, gdouble x, struct graph_info *ginfo)
 {
 	gdk_draw_line(widget->window, widget->style->black_gc,
-		      x, 0, x, widget->allocation.width);
+		      x, 0, x, widget->allocation.height);
 }
 
 static void clear_line(struct graph_info *ginfo, gint x)
-- 
1.7.7.3


  parent reply	other threads:[~2012-11-15  1:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15  1:51 [PATCH 1/4] kernelshark: Fix bug with Plot CPU filtering David Sharp
2012-11-15  1:51 ` [PATCH 2/4] kernel-shark: Allow unsetting of all CPUs in filter David Sharp
2012-11-15  2:20   ` Steven Rostedt
2012-11-15  1:51 ` [PATCH 3/4] kernel-shark: Don't check for system name for sched events David Sharp
2012-11-15  1:51 ` David Sharp [this message]
2012-11-15  2:27   ` [PATCH 4/4] kernelshark: Full-height cursor and mark lines Steven Rostedt
2012-11-15 19:55     ` David Sharp
2012-11-15  1:52 ` [PATCH 1/4] kernelshark: Fix bug with Plot CPU filtering David Sharp
2012-11-15  2:31   ` Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2012-11-15  1:48 David Sharp
2012-11-15  1:48 ` [PATCH 4/4] kernelshark: Full-height cursor and mark lines David Sharp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352944274-21699-4-git-send-email-dhsharp@google.com \
    --to=dhsharp@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.