Re: [PATCH 1/2] dw_dmac: check direction properly in dw_dma_cyclic_prep

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, 2012-11-15 at 20:28 +0530, viresh kumar wrote: 
> On Thu, Nov 15, 2012 at 8:05 PM, viresh kumar <viresh.kumar@linaro.org> wrote:
> > On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> >> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> >
> >> +static inline bool is_slave_direction(enum dma_transfer_direction direction)
> >> +{
> >> +       return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);
> >> +}
> >
> > I would add this in dmaengine.h and will also include check for DMA_DEV_TO_DEV.
> 
> Also, what about is_slave_xfer() name?

No objections.


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy