From: Shuah Khan <shuah.khan@hp.com>
To: Richard Kuo <rkuo@codeaurora.org>, m.szyprowski@samsung.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
arnd@arndb.de, kyungmin.park@samsung.com, linas@codeaurora.org,
linux-hexagon@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
shuahkhan@gmail.com
Subject: Re: [PATCH RFT RESEND linux-next] hexagon: dma-mapping: support debug_dma_mapping_error
Date: Thu, 15 Nov 2012 10:57:29 -0700 [thread overview]
Message-ID: <1353002249.2532.36.camel@lorien2> (raw)
In-Reply-To: <20121105010859.GA20521@codeaurora.org>
On Sun, 2012-11-04 at 19:08 -0600, Richard Kuo wrote:
> On Fri, Nov 02, 2012 at 10:48:21AM -0600, Shuah Khan wrote:
> > On Fri, 2012-10-26 at 09:43 -0600, Shuah Khan wrote:
> > > Add support for debug_dma_mapping_error() call to avoid warning from
> > > debug_dma_unmap() interface when it checks for mapping error checked
> > > status. Without this patch, device driver failed to check map error
> > > warning is generated.
> > >
> > > Signed-off-by: Shuah Khan <shuah.khan@hp.com>
> > > ---
> > > arch/hexagon/include/asm/dma-mapping.h | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > Would you like se this patch go through arch tree or linux-next? Please
> > let me know your preference.
> >
> > -- Shuah
> > >
> > > diff --git a/arch/hexagon/include/asm/dma-mapping.h b/arch/hexagon/include/asm/dma-mapping.h
> > > index 85e9935..1957c4c 100644
> > > --- a/arch/hexagon/include/asm/dma-mapping.h
> > > +++ b/arch/hexagon/include/asm/dma-mapping.h
> > > @@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
> > > {
> > > struct dma_map_ops *dma_ops = get_dma_ops(dev);
> > >
> > > + debug_dma_mapping_error(dev, dma_addr);
> > > if (dma_ops->mapping_error)
> > > return dma_ops->mapping_error(dev, dma_addr);
> > >
> >
> >
>
> This looks fine; I'm OK with this going through linux-next. Thanks!
>
> Acked-by: Richard Kuo <rkuo@codeaurora.org>
>
Marek,
This one is for hexagon to go through your tree with the other arch
patches for debug_dma_mapping_error().
Thanks,
-- Shuah
prev parent reply other threads:[~2012-11-15 17:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 23:12 [PATCH RFT] hexagon: dma-mapping: support debug_dma_mapping_error Shuah Khan
2012-10-26 15:43 ` [PATCH RFT RESEDN linux-next] " Shuah Khan
2012-11-02 16:48 ` [PATCH RFT RESEND " Shuah Khan
2012-11-05 1:08 ` Richard Kuo
2012-11-15 17:57 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353002249.2532.36.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=kyungmin.park@samsung.com \
--cc=linas@codeaurora.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rkuo@codeaurora.org \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.