From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] spi: mxc_spi: Fix spi clock glitch durant reset
Date: Thu, 15 Nov 2012 19:23:24 -0200 [thread overview]
Message-ID: <1353014604-26493-4-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1353014604-26493-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@freescale.com>
Measuring the spi clock line on a scope shows a 'glitch' during the reset of the
spi.
Fix this by toggling only the MXC_CSPICTRL_EN bit, so that the clock line becomes
always stable.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/spi/mxc_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
index 4bed4f0..102fca5 100644
--- a/drivers/spi/mxc_spi.c
+++ b/drivers/spi/mxc_spi.c
@@ -140,8 +140,8 @@ static s32 spi_cfg_mxc(struct mxc_spi_slave *mxcs, unsigned int cs,
reg_ctrl = reg_read(®s->ctrl);
/* Reset spi */
- reg_write(®s->ctrl, 0);
- reg_write(®s->ctrl, (reg_ctrl | 0x1));
+ reg_write(®s->ctrl, (reg_ctrl & ~MXC_CSPICTRL_EN));
+ reg_write(®s->ctrl, (reg_ctrl | MXC_CSPICTRL_EN));
/*
* The following computation is taken directly from Freescale's code.
--
1.7.9.5
next prev parent reply other threads:[~2012-11-15 21:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 21:23 [U-Boot] [PATCH 1/4] mx5: Align SPI CS naming with i.MX53 reference manual Fabio Estevam
2012-11-15 21:23 ` [U-Boot] [PATCH 2/4] mx5: Print CSPI clock in 'clock' command Fabio Estevam
2012-11-16 6:35 ` Dirk Behme
2012-11-16 11:15 ` Fabio Estevam
2012-11-16 13:18 ` Stefano Babic
2012-11-15 21:23 ` [U-Boot] [PATCH 3/4] spi: mxc_spi: Fix handling of chip select Fabio Estevam
2012-11-15 21:23 ` Fabio Estevam [this message]
2012-11-16 13:17 ` [U-Boot] [PATCH 4/4] spi: mxc_spi: Fix spi clock glitch durant reset Stefano Babic
2012-11-19 7:51 ` [U-Boot] [PATCH 1/4] mx5: Align SPI CS naming with i.MX53 reference manual Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353014604-26493-4-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.