From: Constantine Shulyupin <const@MakeLinux.com>
To: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
Andy Whitcroft <apw@canonical.com>
Cc: Constantine Shulyupin <const@MakeLinux.com>
Subject: [PATCH] checkpatch: debugfs_remove() can take NULL
Date: Sat, 17 Nov 2012 14:33:01 +0200 [thread overview]
Message-ID: <1353155581-30852-1-git-send-email-const@MakeLinux.com> (raw)
From: Constantine Shulyupin <const@MakeLinux.com>
debugfs_remove() can take a NULL, so let's check and warn about that.
Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
---
scripts/checkpatch.pl | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f18750e..c062476 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3221,6 +3221,14 @@ sub process {
"kfree(NULL) is safe this check is probably not required\n" . $hereprev);
}
}
+# check for needless debugfs_remove() checks
+ if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
+ my $expr = $1;
+ if ($line =~ /\bdebugfs_remove\(\Q$expr\E\);/) {
+ WARN("NEEDLESS_DEBUGFS_REMOVE",
+ "debugfs_remove(NULL) is safe this check is probably not required\n" . $hereprev);
+ }
+ }
# check for needless usb_free_urb() checks
if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
my $expr = $1;
--
1.7.9.5
next reply other threads:[~2012-11-17 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 12:33 Constantine Shulyupin [this message]
2012-11-17 13:30 ` [PATCH] checkpatch: debugfs_remove() can take NULL Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353155581-30852-1-git-send-email-const@MakeLinux.com \
--to=const@makelinux.com \
--cc=apw@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.