From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] parse/cache/cooker: Preserve order in the file inclusion list
Date: Mon, 19 Nov 2012 15:20:21 +0000 [thread overview]
Message-ID: <1353338421.3709.171.camel@ted> (raw)
In-Reply-To: <20121119150931.GA3341@jama.jama.net>
On Mon, 2012-11-19 at 16:09 +0100, Martin Jansa wrote:
> On Mon, Nov 19, 2012 at 03:01:20PM +0000, Richard Purdie wrote:
> > The data returned by get_file_depends() may me used in contexts like
> > checksums where order is important. The current usage of sets means
> > that some of the checksums can change in circumstances they should not.
> >
> > This patch changes to use lists, thereby removing the problem.
>
> Should this cover also BBINCLUDED variable in parsing cache?
>
> Sometimes I see all recipes reparsed without any reason (no change in
> metadata).
>
> Comparing output of bitbake -p (with added patch to dump parse data,
> shows order of BBINCLUDED changing.
Yes, this is exactly why I'm proposing this patch.
Cheers,
Richard
prev parent reply other threads:[~2012-11-19 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 15:01 [PATCH] parse/cache/cooker: Preserve order in the file inclusion list Richard Purdie
2012-11-19 15:09 ` Martin Jansa
2012-11-19 15:20 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353338421.3709.171.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=martin.jansa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.