All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/2] pwm fixes for 3.8
Date: Tue, 20 Nov 2012 06:44:44 +1300	[thread overview]
Message-ID: <1353347086-4572-1-git-send-email-linux@prisktech.co.nz> (raw)

Hi Theirry,

I felt the error message for clk_enable in vt8500_pwm_config() needed
to somehow indicate that the clk_enable failed in this function otherwise
if there is a problem, you can't tell which of the clk_enable's
generated the fail message.
If there is a clock error - as you pointed out - it will probably fail
elsewhere as well so I've changed it to match the other error messages.

These should be applied on top of the original patch.

v2: Add error checking for clk_enable()
v3: Remove superfluous ;'s. Error message style correction.

Tony Prisk (2):
  Fix build error in pwm-vt8500.c
  pwm: vt8500: Ensure pwm clock is enabled during pwm_config

 drivers/pwm/pwm-vt8500.c |   16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

-- 
1.7.9.5

             reply	other threads:[~2012-11-19 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 17:44 Tony Prisk [this message]
2012-11-19 17:44 ` [PATCH v3 1/2] Fix build error in pwm-vt8500.c Tony Prisk
2012-11-19 17:44 ` [PATCH v3 2/2] pwm: vt8500: Ensure pwm clock is enabled during pwm_config Tony Prisk
2012-11-20 12:16 ` [PATCH v3 0/2] pwm fixes for 3.8 Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353347086-4572-1-git-send-email-linux@prisktech.co.nz \
    --to=linux@prisktech.co.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.