From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hans de Goede <hdegoede@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 3/7] uhci: Fix double unlink
Date: Wed, 21 Nov 2012 15:00:00 +0100 [thread overview]
Message-ID: <1353506404-29446-4-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1353506404-29446-1-git-send-email-kraxel@redhat.com>
From: Hans de Goede <hdegoede@redhat.com>
uhci_async_cancel() already does a uhci_async_unlink().
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/hcd-uhci.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c
index 078be2a..8e47803 100644
--- a/hw/usb/hcd-uhci.c
+++ b/hw/usb/hcd-uhci.c
@@ -963,7 +963,6 @@ static void uhci_async_complete(USBPort *port, USBPacket *packet)
UHCIState *s = async->queue->uhci;
if (packet->status == USB_RET_REMOVE_FROM_QUEUE) {
- uhci_async_unlink(async);
uhci_async_cancel(async);
return;
}
--
1.7.1
next prev parent reply other threads:[~2012-11-21 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 13:59 [Qemu-devel] [PULL for-1.3 0/7] usb patch queue Gerd Hoffmann
2012-11-21 13:59 ` [Qemu-devel] [PATCH 1/7] uhci: Add a completions_only flag for async completions Gerd Hoffmann
2012-11-21 13:59 ` [Qemu-devel] [PATCH 2/7] uhci: Don't allow the guest to set port-enabled when there is no dev connected Gerd Hoffmann
2012-11-21 14:00 ` Gerd Hoffmann [this message]
2012-11-21 14:00 ` [Qemu-devel] [PATCH 4/7] usb-bt: Return NAK instead of STALL when interrupt ep has no data Gerd Hoffmann
2012-11-21 14:00 ` [Qemu-devel] [PATCH 5/7] usb-smartcard-reader: Properly NAK interrupt eps when we've no events Gerd Hoffmann
2012-11-21 14:00 ` [Qemu-devel] [PATCH 6/7] usb-redir: Split usb_handle_interrupt_data into separate in/out functions Gerd Hoffmann
2012-11-21 14:00 ` [Qemu-devel] [PATCH 7/7] usb-redir: Don't handle interrupt output packets async Gerd Hoffmann
2012-11-26 15:34 ` [Qemu-devel] [PULL for-1.3 0/7] usb patch queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353506404-29446-4-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.