From: Tom Zanussi <tom.zanussi@intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-intel][danny][PATCH V2] mesa-dri_8.0.4.bbappend: Remove tabs from python code
Date: Thu, 22 Nov 2012 00:26:57 -0600 [thread overview]
Message-ID: <1353565617.7717.154.camel@empanada> (raw)
In-Reply-To: <1353530214-3748-1-git-send-email-raj.khem@gmail.com>
On Wed, 2012-11-21 at 12:36 -0800, Khem Raj wrote:
> check for xserver to be non-empty before using it
> fixed errors like
>
> ERROR: Failed to parse recipe:
> /b/kraj/yocto/poky/meta/recipes-graphics/mesa/mesa-dri_8.0.4.bb
> ERROR: Error executing a python function in <code>:
> AttributeError: 'NoneType' object has no attribute 'split'
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Pulled into meta-intel/master and meta-intel/danny-next.
Thanks,
Tom
> ---
> .../recipes-graphics/mesa/mesa-dri_8.0.4.bbappend | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/recipes-graphics/mesa/mesa-dri_8.0.4.bbappend b/common/recipes-graphics/mesa/mesa-dri_8.0.4.bbappend
> index 6bfa968..b92831d 100644
> --- a/common/recipes-graphics/mesa/mesa-dri_8.0.4.bbappend
> +++ b/common/recipes-graphics/mesa/mesa-dri_8.0.4.bbappend
> @@ -6,13 +6,13 @@
> python __anonymous () {
> import re
> xserver = d.getVar('XSERVER', True)
> - if 'emgd-driver-bin' in xserver.split(' '):
> + if xserver and 'emgd-driver-bin' in xserver.split(' '):
> extra_oeconf = d.getVar('EXTRA_OECONF', True).split()
> - take_out = ["--enable-egl", "--enable-gles1", "--enable-gles2"]
> - put_in = ["--disable-egl", "--disable-gles1", "--disable-gles2"]
> + take_out = ["--enable-egl", "--enable-gles1", "--enable-gles2"]
> + put_in = ["--disable-egl", "--disable-gles1", "--disable-gles2"]
> pattern = re.compile("--with-egl-platforms")
> new_extra_oeconf = [ ]
> - for i in extra_oeconf:
> + for i in extra_oeconf:
> if ( i not in take_out ) and ( not pattern.match(i)):
> new_extra_oeconf.append(i)
> for i in put_in:
prev parent reply other threads:[~2012-11-22 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 20:36 [meta-intel][danny][PATCH V2] mesa-dri_8.0.4.bbappend: Remove tabs from python code Khem Raj
2012-11-22 6:26 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353565617.7717.154.camel@empanada \
--to=tom.zanussi@intel.com \
--cc=raj.khem@gmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.