From: Peter Hurley <peter@hurleysoftware.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: linux-next: Tree for Nov 26 (staging/fwserial)
Date: Tue, 27 Nov 2012 02:39:10 -0500 [thread overview]
Message-ID: <1354001950.3284.23.camel@thor> (raw)
In-Reply-To: <20121126152001.bf346786.akpm@linux-foundation.org>
On Mon, 2012-11-26 at 15:20 -0800, Andrew Morton wrote:
> On Mon, 26 Nov 2012 12:56:07 -0800
> Randy Dunlap <rdunlap@infradead.org> wrote:
>
> > On 11/26/2012 06:17 AM, Stephen Rothwell wrote:
> >
> > > Hi all,
> > >
> > > Changes since 20121115:
> > >
> >
> >
> > on i386:
> >
> > drivers/staging/fwserial/dma_fifo.c: In function 'dma_fifo_in':
> > drivers/staging/fwserial/dma_fifo.c:174:2: error: implicit declaration of function '__WARN_printf'
> >
>
> That should be replaced with WARN(fifo->corrupt, format).
Yeah, not sure what I was thinking there. Or rather not thinking.
> drivers/staging/fwserial/dma_fifo.[ch] appear to be generic code and
> really should be proposed for mm/ or lib/.
If there are other users for which this would be useful, that's ok with
me. I'd feel more comfortable with that after this driver gets some
heavier usage (which shouldn't be a problem once I get a console and
debugger running on top of it).
next prev parent reply other threads:[~2012-11-27 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 14:17 linux-next: Tree for Nov 26 Stephen Rothwell
2012-11-26 14:17 ` Stephen Rothwell
2012-11-26 19:07 ` [PATCH -next] tty/serial: fix ifx6x60.c declaration warning Randy Dunlap
2012-11-26 19:43 ` linux-next: Tree for Nov 26 (mmc/host/tifm_sd.c) Randy Dunlap
2012-11-26 20:56 ` linux-next: Tree for Nov 26 (staging/fwserial) Randy Dunlap
2012-11-26 23:20 ` Andrew Morton
2012-11-27 7:39 ` Peter Hurley [this message]
2012-11-27 7:11 ` [PATCH -next] staging/fwserial: Fix build breakage when !CONFIG_BUG Peter Hurley
2012-11-27 18:42 ` Randy Dunlap
2012-11-28 0:56 ` Peter Hurley
2012-11-27 7:17 ` linux-next: Tree for Nov 26 (staging/fwserial) Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354001950.3284.23.camel@thor \
--to=peter@hurleysoftware.com \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.