From: Eric Leblond <eric@regit.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] build: move remaining preprocessor flags into CPPFLAGS
Date: Tue, 27 Nov 2012 14:09:57 +0100 [thread overview]
Message-ID: <1354021797.4103.13.camel@tiger2> (raw)
In-Reply-To: <1354020546-4799-2-git-send-email-jengelh@inai.de>
Hi,
On Tue, 2012-11-27 at 13:49 +0100, Jan Engelhardt wrote:
> The flags retrieved from `pkg-config --cflags ...` are generally only
> preprocessor flags (mostly -I to point to the directories), since
> anything else would inconvenience downstream users.
>
...
> -AM_CPPFLAGS = -I$(top_srcdir)/include
> -AM_CFLAGS = ${regular_CFLAGS} ${libsqlite3_CFLAGS}
> +AM_CPPFLAGS = -I$(top_srcdir)/include ${libsqlite3_CFLAGS}
> +AM_CFLAGS = ${regular_CFLAGS}
>
> if HAVE_SQLITE3
All four patches have been applied. Thanks a lot Jan.
BR,
--
Eric Leblond <eric@regit.org>
Blog: https://home.regit.org/
prev parent reply other threads:[~2012-11-27 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 12:49 [PATCH 1/2] build: avoid per-target CFLAGS Jan Engelhardt
2012-11-27 12:49 ` [PATCH 2/2] build: move remaining preprocessor flags into CPPFLAGS Jan Engelhardt
2012-11-27 13:09 ` Eric Leblond [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354021797.4103.13.camel@tiger2 \
--to=eric@regit.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.