From: Peter Hurley <peter@hurleysoftware.com>
To: Alan Cox <alan@linux.intel.com>
Cc: Ilya Zykov <ilya@ilyx.ru>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Xiaobing Tu <xiaobing.tu@intel.com>, Jiri Slaby <jslaby@suse.cz>,
Alek Du <alek.du@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: Correct tty buffer flushing.
Date: Thu, 29 Nov 2012 20:14:14 -0500 [thread overview]
Message-ID: <1354238054.2860.18.camel@thor> (raw)
In-Reply-To: <20121129212809.5bc12088@bob.linux.org.uk>
On Thu, 2012-11-29 at 21:28 +0000, Alan Cox wrote:
> > Sorry, In you reply not all patch.
> > Main idea here - we never flash last (struct tty_buffer) in the
> > active buffer. Only data for ldisc. (tty->buf.head->read =
> > tty->buf.head->commit). At that moment driver can collect(write) data
> > in buffer without conflict.
>
> Ah.. now I understand. Yes that makes sense. I will think about that
> carefully. This is why a good explanation with a patch is important.
FWIW, I've been running this on -next. The logic seems sound to me --
fundamentally, this technique is what flush_to_ldisc() does.
Regards,
Peter Hurley
next prev parent reply other threads:[~2012-11-30 1:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 0:28 [PATCH] tty: Correct tty buffer flushing Ilya Zykov
2012-11-29 0:03 ` Fwd: " Ilya Zykov
2012-11-29 13:54 ` Alan Cox
2012-11-29 14:03 ` Ilya Zykov
2012-11-29 14:13 ` Ilya Zykov
2012-11-29 21:28 ` Alan Cox
2012-11-30 1:14 ` Peter Hurley [this message]
2012-12-04 8:53 ` Alan Cox
2012-12-04 10:11 ` Ilya Zykov
2012-11-29 17:48 ` Ilya Zykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354238054.2860.18.camel@thor \
--to=peter@hurleysoftware.com \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alek.du@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilya@ilyx.ru \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=xiaobing.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.