From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re[2]: [PATCH 1/2] ARM: ixp4xx: Moving the timer flags control in ixp4xx_irq_ack() procedure
Date: Sun, 02 Dec 2012 17:50:37 +0400 [thread overview]
Message-ID: <1354456237.324126069@f360.mail.ru> (raw)
In-Reply-To: <20667.22941.433988.716964@pilspetsen.it.uu.se>
> Alexander Shiyan writes:
> > Rather than modify the EOI flags directly in the timer interrupt,
> > let's deal with these flags in the ixp4xx_irq_ack() procedure.
>
> Why?
>
> All I see is that you're removing simple unconditional code from two
> interrupt handlers and adding a large conditional to ixp4xx_irq_ack,
> which will slow down all interrupt acks.
>
> So in what way is this an improvement?
This is a right place for do it. Now we can use these interrupts in any
drivers without patching last one for touching ACK.
---
prev parent reply other threads:[~2012-12-02 13:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 7:33 [PATCH] ARM: ixp4xx: Add "ask" handler for timer interrupts Alexander Shiyan
2012-12-01 13:05 ` Jason Cooper
2012-12-01 13:14 ` Re[2]: " Alexander Shiyan
2012-12-01 15:41 ` Jason Cooper
2012-12-01 21:25 ` Arnd Bergmann
2012-12-01 21:45 ` Jason Cooper
2012-12-02 0:11 ` Arnd Bergmann
2012-12-02 6:02 ` Re[2]: " Alexander Shiyan
2012-12-02 13:13 ` Arnd Bergmann
2012-12-02 13:55 ` Re[4]: " Alexander Shiyan
2012-12-03 23:40 ` Arnd Bergmann
2012-12-02 8:09 ` [PATCH 1/2] ARM: ixp4xx: Moving the timer flags control in ixp4xx_irq_ack() procedure Alexander Shiyan
2012-12-02 8:09 ` [PATCH 2/2] ARM: ixp4xx: Using gpiolib rather than a private GPIO API Alexander Shiyan
2012-12-02 13:25 ` Arnd Bergmann
2012-12-02 13:24 ` [PATCH 1/2] ARM: ixp4xx: Moving the timer flags control in ixp4xx_irq_ack() procedure Arnd Bergmann
2012-12-02 13:37 ` Mikael Pettersson
2012-12-02 13:50 ` Alexander Shiyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354456237.324126069@f360.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.