All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>,
	Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/2] dracut: add team device support
Date: Mon, 03 Dec 2012 11:27:03 +0800	[thread overview]
Message-ID: <1354505223.28101.11.camel@cr0> (raw)
In-Reply-To: <50BC1871.4050009-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Mon, 2012-12-03 at 11:11 +0800, Dave Young wrote:
> > -    instmods =drivers/net/phy ecb arc4 bridge stp llc ipv6 bonding
> 8021q af_packet virtio_net
> > +    instmods =drivers/net/phy ecb arc4 bridge stp llc ipv6 bonding
> 8021q af_packet virtio_net =drivers/net/team
> 
> 
> 
> 40network installs all related kernel modules. This will create a big
> initramfs though some of them are not used at all.
> 
> I'm thinking it's better to conditionally install them. In the long
> run
> maybe network module should be splited to to multiple modules.
> 
> And for now I think it's better to install them only if there's team
> related user space tools in running system. 

It is not as easy as what you think, users may specify their network
config at _run time_ via cmdline, so it is not easy to know which kernel
module will be used until we get all the cmdline.

For kdump, one solution is removing all unnecessary stuffs including
kernel modules and user-space utitlies at setup time, because kdump
parses the network config at setup time. Obviously this only applies for
kdump, for others, e.g. anaconda, this problem still exists, but they
probably don't care about the memory usage as much as kdump.

However, I don't think this is relevant here, we should do this in a
different patch. It is unfair to only blame team driver here, there are
already some other modules in the same line anyway...


  parent reply	other threads:[~2012-12-03  3:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 14:58 [PATCH 1/2] dracut: add team device support Cong Wang
     [not found] ` <1352991509-31740-1-git-send-email-amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-11-15 14:58   ` [PATCH 2/2] dracut: document team cmdline Cong Wang
2012-12-01  3:24   ` [PATCH 1/2] dracut: add team device support Cong Wang
2012-12-03  3:11   ` Dave Young
     [not found]     ` <50BC1871.4050009-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-12-03  3:27       ` Cong Wang [this message]
2012-12-03  5:27         ` Dave Young
     [not found]           ` <50BC3834.3040908-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-12-03  5:53             ` Cong Wang
2012-12-03 14:24         ` Jiri Pirko
     [not found]           ` <20121203142452.GB3054-RDzucLLXGGI88b5SBfVpbw@public.gmane.org>
2012-12-04 22:18             ` Vivek Goyal
     [not found]               ` <20121204221839.GE5738-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-12-05  3:14                 ` Cong Wang
2012-12-13  5:12                 ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354505223.28101.11.camel@cr0 \
    --to=amwang-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.