All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, Tejun Heo <tj@kernel.org>,
	Brian Norris <computersforpeace@gmail.com>,
	David Daney <david.daney@cavium.com>
Subject: [PATCH v2 2/4] pata_octeon_cf: perform host detach, removal on exit
Date: Mon,  3 Dec 2012 10:34:40 -0800	[thread overview]
Message-ID: <1354559682-30965-2-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1354559682-30965-1-git-send-email-computersforpeace@gmail.com>

This driver does not detach and remove its ata_host properly on device
removal. Add the common .remove helper.

Note: I do not know this driver well enough to ensure this is the right
thing to do. Merge this patch with caution.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: David Daney <david.daney@cavium.com>
---
v2: no change (rebased along with previous patch)

 drivers/ata/pata_octeon_cf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index 1d61d5d..d8df93b 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
@@ -921,6 +921,7 @@ free_cf_port:
 
 static struct platform_driver octeon_cf_driver = {
 	.probe		= octeon_cf_probe,
+	.remove		= ata_platform_remove_one,
 	.driver		= {
 		.name	= DRV_NAME,
 		.owner	= THIS_MODULE,
-- 
1.8.0


  reply	other threads:[~2012-12-03 18:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03 18:34 [PATCH v3 1/4] sata_highbank: utilize common ata_platform_remove_one() Brian Norris
2012-12-03 18:34 ` Brian Norris [this message]
2012-12-04  0:26   ` [PATCH v2 2/4] pata_octeon_cf: perform host detach, removal on exit David Daney
2012-12-04  6:10     ` Brian Norris
2012-12-14 14:37       ` Jeff Garzik
2012-12-03 18:34 ` [PATCH v2 3/4] libata: use pci_get_drvdata() helper Brian Norris
2012-12-03 18:34 ` [PATCH v2 4/4] pata_of_platform: fix compile error Brian Norris
2012-12-03 18:55 ` [PATCH v3 1/4] sata_highbank: utilize common ata_platform_remove_one() Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354559682-30965-2-git-send-email-computersforpeace@gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=david.daney@cavium.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.