From mboxrd@z Thu Jan  1 00:00:00 1970
From: Imre Deak <imre.deak@intel.com>
Subject: Re: [PATCH 02/10] drm/i915: don't handle
 PIPE_LEGACY_BLC_EVENT_STATUS on vlv
Date: Tue, 04 Dec 2012 16:37:55 +0200
Message-ID: <1354631875.746.1.camel@localhost>
References: <1354366429-2324-1-git-send-email-daniel.vetter@ffwll.ch>
	<1354366429-2324-3-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3C976E6001
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  4 Dec 2012 06:37:58 -0800 (PST)
In-Reply-To: <1354366429-2324-3-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, 2012-12-01 at 13:53 +0100, Daniel Vetter wrote:
> This is for legacy legacy stuff, and checking with the leftover
> pipe from the previous loop is propably not what we want. Since
> pipe == 2 after the loop ...

This doesn't seem to match the change, blc_event is simply never used
here.

> 
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index ff78818..2028137 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -533,7 +533,6 @@ static irqreturn_t valleyview_irq_handler(int irq, void *arg)
>  	unsigned long irqflags;
>  	int pipe;
>  	u32 pipe_stats[I915_MAX_PIPES];
> -	bool blc_event;
>  
>  	atomic_inc(&dev_priv->irq_received);
>  
> @@ -590,9 +589,6 @@ static irqreturn_t valleyview_irq_handler(int irq, void *arg)
>  			I915_READ(PORT_HOTPLUG_STAT);
>  		}
>  
> -		if (pipe_stats[pipe] & PIPE_LEGACY_BLC_EVENT_STATUS)
> -			blc_event = true;
> -
>  		if (pm_iir & GEN6_PM_DEFERRED_EVENTS)
>  			gen6_queue_rps_work(dev_priv, pm_iir);
>