From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 00/10] gmbus/dp aux irqfication Date: Tue, 04 Dec 2012 18:04:48 +0200 Message-ID: <1354637088.746.3.camel@localhost> References: <1354366429-2324-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C340E638C for ; Tue, 4 Dec 2012 08:04:51 -0800 (PST) In-Reply-To: <1354366429-2324-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Sat, 2012-12-01 at 13:53 +0100, Daniel Vetter wrote: > Hi all, > > Irq-drive gmbus/dp aux transfer, simply because we can (and at least in the case > of gmbus, it's quite a bit faster than the msleep(1) loop - we now reliably > transfer at full wire speed insteaf of sometimes 2-3x slower). > > Compared to the older version I've floated on irc way back and which Chris has > carried around in his wip branchs (and inflicted upon tons of unsuspecting bug > reporters) there are a few differences: > - handle the hpd vs. setup race - even the current code enables hpd processing > before the fbdev is set up, which is too early. > - fix the gen4 gmbus support, was totally busted. > - tested on hsw (although all the relevant bits are a 100% match with cpt/ivb). > - disable dp aux irq on vlv - too complicated to get at the docs (moved again, > old access revoked) and I don't have the hw. > > While reviewing this patch series I've also noticed two small things in the irq > handling code in general, patches for that at the beginning of the series. > > Comment&review highgly welcome. Looks good to me. On the series: Reviewed-by: Imre Deak > > Cheers, Daniel > > Daniel Vetter (10): > drm/i915: haswell has the same irq handlers as ivb > drm/i915: don't handle PIPE_LEGACY_BLC_EVENT_STATUS on vlv > drm/i915: reorder setup sequence to have irqs for output setup > drm/i915: extract gmbus_wait_hw_status > drm/i915: wire up gmbus irq handler > drm/i915: use the gmbus irq for waits > drm/i915: use gmbus irq to wait for gmbus idle > drm/i915: wire up do aux channel done interrupt > drm/i915: irq-drive the dp aux communication > drm/i915: use _NOTRACE for gmbus/dp aux wait loops > > drivers/gpu/drm/i915/i915_dma.c | 10 +++- > drivers/gpu/drm/i915/i915_drv.h | 8 ++++ > drivers/gpu/drm/i915/i915_irq.c | 74 ++++++++++++++++++++-------- > drivers/gpu/drm/i915/intel_dp.c | 59 ++++++++++++++++++----- > drivers/gpu/drm/i915/intel_i2c.c | 101 +++++++++++++++++++++++++++++---------- > 5 files changed, 193 insertions(+), 59 deletions(-) >