From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anton Blanchard <anton@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org, amodra@gmail.com
Subject: Re: [PATCH 1/3] powerpc: Relocate prom_init.c on 64bit
Date: Wed, 05 Dec 2012 18:20:31 +1100 [thread overview]
Message-ID: <1354692031.2351.4.camel@pasglop> (raw)
In-Reply-To: <20121205110723.68839261@kryten>
On Wed, 2012-12-05 at 11:07 +1100, Anton Blanchard wrote:
> Hi Ben,
>
> > My only potential objection was that it might have been cleaner to
> > actually build prom_init.c as a separate binary alltogether and piggy
> > back it...
>
> Yeah, I went through a number of options before settling on this one.
Heh, yeah, that what happens when nothing is fully satisfactory...
.../...
> Build prom_init.c 32 bit, tack it onto the end of the vmlinux and
> add a trampoline at the start of the vmlinux.
>
> This means a vmlinux will be bootable and profiling tools will work
> against it. Even so it feels gross to me.
It does, might be less gross to have prom_init.c be .incbin'ed in
vmlinux like the vdso is ... better than tacking it at the end. Still
makes it annoying to debug crashes in prom_init itself.
I'll review your patch when I get a chance as the "least bad"
solution :-)
Cheers,
Ben.
prev parent reply other threads:[~2012-12-05 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 3:39 [PATCH 1/3] powerpc: Relocate prom_init.c on 64bit Anton Blanchard
2012-11-27 3:40 ` [PATCH 2/3] powerpc: Remove RELOC() macro Anton Blanchard
2012-11-27 3:41 ` [PATCH 3/3] powerpc: Build kernel with -mcmodel=medium Anton Blanchard
2012-11-27 5:22 ` [PATCH 1/3] powerpc: Relocate prom_init.c on 64bit Benjamin Herrenschmidt
2012-12-05 0:07 ` Anton Blanchard
2012-12-05 7:20 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354692031.2351.4.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.