From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <raistlin@linux.it>
Subject: Re: [PATCH 3 of 3] xen: sched_credit: add some tracing
Date: Wed, 05 Dec 2012 13:15:54 +0100
Message-ID: <1354709754.21632.31.camel@Abyss>
References: <patchbomb.1354552497@Solace>
	<bf4b06eda19a03a6aa0b.1354552500@Solace>	<50BE4AC2.9010507@eu.citrix.com>
	<1354708472.21632.21.camel@Abyss>
	<1354708869.15296.173.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4656008493446154556=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1354708869.15296.173.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, xen-devel <xen-devel@lists.xensource.com>, "Keir (Xen.org)" <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org


--===============4656008493446154556==
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-AmXBMiv0fP4S0W9fi3vp"


--=-AmXBMiv0fP4S0W9fi3vp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2012-12-05 at 12:01 +0000, Ian Campbell wrote:=20
> > As I tried to explain in the comment, I just wanted to avoid checking
> > for !tb_init_done more than once, as this happens within a loop and, at
> > least potentially, there may be more CPUs to tickle (and thus more call=
s
> > to TRACE_1D).
>=20
> If tb_init_done isn't marked volatile or anything like that isn't the
> check hoisted out of the loop by the compiler?
>=20
Good point. As they're all macros, yes, I think that is something very
likely to happen... Although, I haven't checked the generated code, I'll
take a look. Thanks.

> > I take this comment of yours as you not thinking that is
> > something worthwhile, right? If so, I can definitely turn this into a
> > "standard" TRACE_1D() call.
>=20
> Or maybe consider __TRACE_1D and friends which omit the check?
>=20
Mmm... It may well be me, but my

$ grep __TRACE xen/* -R

does not show any results... What am I missing?

Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



--=-AmXBMiv0fP4S0W9fi3vp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlC/OvoACgkQk4XaBE3IOsRJlgCfZl12ClbD6wpY8zMSJyaPJL5M
88IAn0fUSPtsY6rfdeA8/y1v2KCXj/wC
=Fsfd
-----END PGP SIGNATURE-----

--=-AmXBMiv0fP4S0W9fi3vp--



--===============4656008493446154556==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4656008493446154556==--